summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>2019-07-10 05:52:50 -0400
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2019-07-10 05:52:50 -0400
commit6cf7fb5a95dec9743f4bfd96f9ece580a355cdd1 (patch)
tree4e2e2f600452b28b7ee5e627e64b7f0331aeb49f
parent4b4704520d97b74e045154fc3b844b73ae4e7ebd (diff)
Revert "ACPICA: Update table load object initialization"
Revert commit c522ad0637ca ("ACPICA: Update table load object initialization") as it causes systems to hang on attempts to load OEM ACPI tables. Reported-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r--drivers/acpi/acpica/exconfig.c16
-rw-r--r--drivers/acpi/acpica/tbxfload.c10
2 files changed, 17 insertions, 9 deletions
diff --git a/drivers/acpi/acpica/exconfig.c b/drivers/acpi/acpica/exconfig.c
index 58c04d706723..587aeeeb5070 100644
--- a/drivers/acpi/acpica/exconfig.c
+++ b/drivers/acpi/acpica/exconfig.c
@@ -174,9 +174,12 @@ acpi_ex_load_table_op(struct acpi_walk_state *walk_state,
174 return_ACPI_STATUS(status); 174 return_ACPI_STATUS(status);
175 } 175 }
176 176
177 /* Complete the initialization/resolution of new objects */ 177 /* Complete the initialization/resolution of package objects */
178 178
179 acpi_ns_initialize_objects(); 179 status = acpi_ns_walk_namespace(ACPI_TYPE_PACKAGE, ACPI_ROOT_OBJECT,
180 ACPI_UINT32_MAX, 0,
181 acpi_ns_init_one_package, NULL, NULL,
182 NULL);
180 183
181 /* Parameter Data (optional) */ 184 /* Parameter Data (optional) */
182 185
@@ -434,11 +437,12 @@ acpi_ex_load_op(union acpi_operand_object *obj_desc,
434 return_ACPI_STATUS(status); 437 return_ACPI_STATUS(status);
435 } 438 }
436 439
437 /* Complete the initialization/resolution of new objects */ 440 /* Complete the initialization/resolution of package objects */
438 441
439 acpi_ex_exit_interpreter(); 442 status = acpi_ns_walk_namespace(ACPI_TYPE_PACKAGE, ACPI_ROOT_OBJECT,
440 acpi_ns_initialize_objects(); 443 ACPI_UINT32_MAX, 0,
441 acpi_ex_enter_interpreter(); 444 acpi_ns_init_one_package, NULL, NULL,
445 NULL);
442 446
443 /* Store the ddb_handle into the Target operand */ 447 /* Store the ddb_handle into the Target operand */
444 448
diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
index 86f1693f6d29..ef8f8a9f3c9c 100644
--- a/drivers/acpi/acpica/tbxfload.c
+++ b/drivers/acpi/acpica/tbxfload.c
@@ -297,11 +297,15 @@ acpi_status acpi_load_table(struct acpi_table_header *table)
297 status = acpi_tb_install_and_load_table(ACPI_PTR_TO_PHYSADDR(table), 297 status = acpi_tb_install_and_load_table(ACPI_PTR_TO_PHYSADDR(table),
298 ACPI_TABLE_ORIGIN_EXTERNAL_VIRTUAL, 298 ACPI_TABLE_ORIGIN_EXTERNAL_VIRTUAL,
299 FALSE, &table_index); 299 FALSE, &table_index);
300 if (ACPI_SUCCESS(status)) {
301 300
302 /* Complete the initialization/resolution of new objects */ 301 if (ACPI_SUCCESS(status)) {
302 /* Complete the initialization/resolution of package objects */
303 303
304 acpi_ns_initialize_objects(); 304 status = acpi_ns_walk_namespace(ACPI_TYPE_PACKAGE,
305 ACPI_ROOT_OBJECT,
306 ACPI_UINT32_MAX, 0,
307 acpi_ns_init_one_package,
308 NULL, NULL, NULL);
305 } 309 }
306 310
307 return_ACPI_STATUS(status); 311 return_ACPI_STATUS(status);