summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2018-10-04 03:10:09 -0400
committerMartin K. Petersen <martin.petersen@oracle.com>2018-10-16 21:54:41 -0400
commit6940d12b3b02fadd9c8cfce551772470976c7ffc (patch)
tree3ef9833124c9c4ce60b60e1dfce8348445353a60
parent20054597f169090109fc3f0dfa1a48583f4178a4 (diff)
scsi: aic94xx: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114988 ("Missing break in switch") Addresses-Coverity-ID: 114989 ("Missing break in switch") Addresses-Coverity-ID: 114990 ("Missing break in switch") Addresses-Coverity-ID: 114991 ("Missing break in switch") Addresses-Coverity-ID: 114992 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r--drivers/scsi/aic94xx/aic94xx_scb.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/scsi/aic94xx/aic94xx_scb.c b/drivers/scsi/aic94xx/aic94xx_scb.c
index 22873ce8bbfa..91ea87dfb700 100644
--- a/drivers/scsi/aic94xx/aic94xx_scb.c
+++ b/drivers/scsi/aic94xx/aic94xx_scb.c
@@ -724,9 +724,11 @@ static void set_speed_mask(u8 *speed_mask, struct asd_phy_desc *pd)
724 switch (pd->max_sas_lrate) { 724 switch (pd->max_sas_lrate) {
725 case SAS_LINK_RATE_6_0_GBPS: 725 case SAS_LINK_RATE_6_0_GBPS:
726 *speed_mask &= ~SAS_SPEED_60_DIS; 726 *speed_mask &= ~SAS_SPEED_60_DIS;
727 /* fall through*/
727 default: 728 default:
728 case SAS_LINK_RATE_3_0_GBPS: 729 case SAS_LINK_RATE_3_0_GBPS:
729 *speed_mask &= ~SAS_SPEED_30_DIS; 730 *speed_mask &= ~SAS_SPEED_30_DIS;
731 /* fall through*/
730 case SAS_LINK_RATE_1_5_GBPS: 732 case SAS_LINK_RATE_1_5_GBPS:
731 *speed_mask &= ~SAS_SPEED_15_DIS; 733 *speed_mask &= ~SAS_SPEED_15_DIS;
732 } 734 }
@@ -734,6 +736,7 @@ static void set_speed_mask(u8 *speed_mask, struct asd_phy_desc *pd)
734 switch (pd->min_sas_lrate) { 736 switch (pd->min_sas_lrate) {
735 case SAS_LINK_RATE_6_0_GBPS: 737 case SAS_LINK_RATE_6_0_GBPS:
736 *speed_mask |= SAS_SPEED_30_DIS; 738 *speed_mask |= SAS_SPEED_30_DIS;
739 /* fall through*/
737 case SAS_LINK_RATE_3_0_GBPS: 740 case SAS_LINK_RATE_3_0_GBPS:
738 *speed_mask |= SAS_SPEED_15_DIS; 741 *speed_mask |= SAS_SPEED_15_DIS;
739 default: 742 default:
@@ -745,6 +748,7 @@ static void set_speed_mask(u8 *speed_mask, struct asd_phy_desc *pd)
745 switch (pd->max_sata_lrate) { 748 switch (pd->max_sata_lrate) {
746 case SAS_LINK_RATE_3_0_GBPS: 749 case SAS_LINK_RATE_3_0_GBPS:
747 *speed_mask &= ~SATA_SPEED_30_DIS; 750 *speed_mask &= ~SATA_SPEED_30_DIS;
751 /* fall through*/
748 default: 752 default:
749 case SAS_LINK_RATE_1_5_GBPS: 753 case SAS_LINK_RATE_1_5_GBPS:
750 *speed_mask &= ~SATA_SPEED_15_DIS; 754 *speed_mask &= ~SATA_SPEED_15_DIS;
@@ -803,6 +807,7 @@ void asd_build_control_phy(struct asd_ascb *ascb, int phy_id, u8 subfunc)
803 807
804 /* link reset retries, this should be nominal */ 808 /* link reset retries, this should be nominal */
805 control_phy->link_reset_retries = 10; 809 control_phy->link_reset_retries = 10;
810 /* fall through */
806 811
807 case RELEASE_SPINUP_HOLD: /* 0x02 */ 812 case RELEASE_SPINUP_HOLD: /* 0x02 */
808 /* decide the func_mask */ 813 /* decide the func_mask */