summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-01-22 10:21:47 -0500
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2019-01-22 17:12:12 -0500
commit659dc4562c1b15e3401ad15338d2109af7c6d718 (patch)
tree86f9e0dae202e6a79075f312961adc69eb4dbfe0
parent49a57857aeea06ca831043acbb0fa5e0f50602fd (diff)
PM: QoS: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r--kernel/power/qos.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/kernel/power/qos.c b/kernel/power/qos.c
index b7a82502857a..9d22131afc1e 100644
--- a/kernel/power/qos.c
+++ b/kernel/power/qos.c
@@ -582,10 +582,8 @@ static int register_pm_qos_misc(struct pm_qos_object *qos, struct dentry *d)
582 qos->pm_qos_power_miscdev.name = qos->name; 582 qos->pm_qos_power_miscdev.name = qos->name;
583 qos->pm_qos_power_miscdev.fops = &pm_qos_power_fops; 583 qos->pm_qos_power_miscdev.fops = &pm_qos_power_fops;
584 584
585 if (d) { 585 debugfs_create_file(qos->name, S_IRUGO, d, (void *)qos,
586 (void)debugfs_create_file(qos->name, S_IRUGO, d, 586 &pm_qos_debug_fops);
587 (void *)qos, &pm_qos_debug_fops);
588 }
589 587
590 return misc_register(&qos->pm_qos_power_miscdev); 588 return misc_register(&qos->pm_qos_power_miscdev);
591} 589}
@@ -685,8 +683,6 @@ static int __init pm_qos_power_init(void)
685 BUILD_BUG_ON(ARRAY_SIZE(pm_qos_array) != PM_QOS_NUM_CLASSES); 683 BUILD_BUG_ON(ARRAY_SIZE(pm_qos_array) != PM_QOS_NUM_CLASSES);
686 684
687 d = debugfs_create_dir("pm_qos", NULL); 685 d = debugfs_create_dir("pm_qos", NULL);
688 if (IS_ERR_OR_NULL(d))
689 d = NULL;
690 686
691 for (i = PM_QOS_CPU_DMA_LATENCY; i < PM_QOS_NUM_CLASSES; i++) { 687 for (i = PM_QOS_CPU_DMA_LATENCY; i < PM_QOS_NUM_CLASSES; i++) {
692 ret = register_pm_qos_misc(pm_qos_array[i], d); 688 ret = register_pm_qos_misc(pm_qos_array[i], d);