diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-01-08 11:27:00 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-01-18 03:58:04 -0500 |
commit | 6041828fdae09b973d3eed4e2c1ae82ddcf28c58 (patch) | |
tree | 6ad1297caf5c4e8cb90024b9e32892cd5bd34dda | |
parent | da79ff6e586bd5aaa3bd9c73e56ae9d9183c3263 (diff) |
uwb: use struct_size() in kzalloc()
One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};
instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:
instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/uwb/drp-ie.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/uwb/drp-ie.c b/drivers/uwb/drp-ie.c index 1d2a939cfcf8..ed993e363472 100644 --- a/drivers/uwb/drp-ie.c +++ b/drivers/uwb/drp-ie.c | |||
@@ -125,9 +125,8 @@ static struct uwb_ie_drp *uwb_drp_ie_alloc(void) | |||
125 | { | 125 | { |
126 | struct uwb_ie_drp *drp_ie; | 126 | struct uwb_ie_drp *drp_ie; |
127 | 127 | ||
128 | drp_ie = kzalloc(sizeof(struct uwb_ie_drp) + | 128 | drp_ie = kzalloc(struct_size(drp_ie, allocs, UWB_NUM_ZONES), |
129 | UWB_NUM_ZONES * sizeof(struct uwb_drp_alloc), | 129 | GFP_KERNEL); |
130 | GFP_KERNEL); | ||
131 | if (drp_ie) | 130 | if (drp_ie) |
132 | drp_ie->hdr.element_id = UWB_IE_DRP; | 131 | drp_ie->hdr.element_id = UWB_IE_DRP; |
133 | return drp_ie; | 132 | return drp_ie; |