diff options
author | Joshua Houghton <josh@awful.name> | 2016-06-18 11:46:31 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-06-19 00:34:09 -0400 |
commit | 5c3da57d70f1ef1d9b60900b84a74d77a9cf0774 (patch) | |
tree | 21dc769db725780191eca09406969756d5ab84e9 | |
parent | 4a7d99ea1b27734558feb6833f180cd38a159940 (diff) |
net: rds: fix coding style issues
Fix coding style issues in the following files:
ib_cm.c: add space
loop.c: convert spaces to tabs
sysctl.c: add space
tcp.h: convert spaces to tabs
tcp_connect.c:remove extra indentation in switch statement
tcp_recv.c: convert spaces to tabs
tcp_send.c: convert spaces to tabs
transport.c: move brace up one line on for statement
Signed-off-by: Joshua Houghton <josh@awful.name>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/rds/ib_cm.c | 2 | ||||
-rw-r--r-- | net/rds/loop.c | 5 | ||||
-rw-r--r-- | net/rds/sysctl.c | 3 | ||||
-rw-r--r-- | net/rds/tcp.h | 2 | ||||
-rw-r--r-- | net/rds/tcp_connect.c | 26 | ||||
-rw-r--r-- | net/rds/tcp_recv.c | 2 | ||||
-rw-r--r-- | net/rds/tcp_send.c | 14 | ||||
-rw-r--r-- | net/rds/transport.c | 3 |
8 files changed, 29 insertions, 28 deletions
diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c index 310cabce2311..7c2a65a6af5c 100644 --- a/net/rds/ib_cm.c +++ b/net/rds/ib_cm.c | |||
@@ -111,7 +111,7 @@ void rds_ib_cm_connect_complete(struct rds_connection *conn, struct rdma_cm_even | |||
111 | } | 111 | } |
112 | } | 112 | } |
113 | 113 | ||
114 | if (conn->c_version < RDS_PROTOCOL(3,1)) { | 114 | if (conn->c_version < RDS_PROTOCOL(3, 1)) { |
115 | printk(KERN_NOTICE "RDS/IB: Connection to %pI4 version %u.%u failed," | 115 | printk(KERN_NOTICE "RDS/IB: Connection to %pI4 version %u.%u failed," |
116 | " no longer supported\n", | 116 | " no longer supported\n", |
117 | &conn->c_faddr, | 117 | &conn->c_faddr, |
diff --git a/net/rds/loop.c b/net/rds/loop.c index 6b12b68541ae..814173b466d9 100644 --- a/net/rds/loop.c +++ b/net/rds/loop.c | |||
@@ -95,8 +95,9 @@ out: | |||
95 | */ | 95 | */ |
96 | static void rds_loop_inc_free(struct rds_incoming *inc) | 96 | static void rds_loop_inc_free(struct rds_incoming *inc) |
97 | { | 97 | { |
98 | struct rds_message *rm = container_of(inc, struct rds_message, m_inc); | 98 | struct rds_message *rm = container_of(inc, struct rds_message, m_inc); |
99 | rds_message_put(rm); | 99 | |
100 | rds_message_put(rm); | ||
100 | } | 101 | } |
101 | 102 | ||
102 | /* we need to at least give the thread something to succeed */ | 103 | /* we need to at least give the thread something to succeed */ |
diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c index c173f69e1479..e381bbcd9cc1 100644 --- a/net/rds/sysctl.c +++ b/net/rds/sysctl.c | |||
@@ -102,7 +102,8 @@ int rds_sysctl_init(void) | |||
102 | rds_sysctl_reconnect_min = msecs_to_jiffies(1); | 102 | rds_sysctl_reconnect_min = msecs_to_jiffies(1); |
103 | rds_sysctl_reconnect_min_jiffies = rds_sysctl_reconnect_min; | 103 | rds_sysctl_reconnect_min_jiffies = rds_sysctl_reconnect_min; |
104 | 104 | ||
105 | rds_sysctl_reg_table = register_net_sysctl(&init_net,"net/rds", rds_sysctl_rds_table); | 105 | rds_sysctl_reg_table = |
106 | register_net_sysctl(&init_net, "net/rds", rds_sysctl_rds_table); | ||
106 | if (!rds_sysctl_reg_table) | 107 | if (!rds_sysctl_reg_table) |
107 | return -ENOMEM; | 108 | return -ENOMEM; |
108 | return 0; | 109 | return 0; |
diff --git a/net/rds/tcp.h b/net/rds/tcp.h index ec0602b0dc24..7940babf6c71 100644 --- a/net/rds/tcp.h +++ b/net/rds/tcp.h | |||
@@ -83,7 +83,7 @@ int rds_tcp_inc_copy_to_user(struct rds_incoming *inc, struct iov_iter *to); | |||
83 | void rds_tcp_xmit_prepare(struct rds_connection *conn); | 83 | void rds_tcp_xmit_prepare(struct rds_connection *conn); |
84 | void rds_tcp_xmit_complete(struct rds_connection *conn); | 84 | void rds_tcp_xmit_complete(struct rds_connection *conn); |
85 | int rds_tcp_xmit(struct rds_connection *conn, struct rds_message *rm, | 85 | int rds_tcp_xmit(struct rds_connection *conn, struct rds_message *rm, |
86 | unsigned int hdr_off, unsigned int sg, unsigned int off); | 86 | unsigned int hdr_off, unsigned int sg, unsigned int off); |
87 | void rds_tcp_write_space(struct sock *sk); | 87 | void rds_tcp_write_space(struct sock *sk); |
88 | 88 | ||
89 | /* tcp_stats.c */ | 89 | /* tcp_stats.c */ |
diff --git a/net/rds/tcp_connect.c b/net/rds/tcp_connect.c index fba13d0305fb..f6e95d60db54 100644 --- a/net/rds/tcp_connect.c +++ b/net/rds/tcp_connect.c | |||
@@ -54,19 +54,19 @@ void rds_tcp_state_change(struct sock *sk) | |||
54 | 54 | ||
55 | rdsdebug("sock %p state_change to %d\n", tc->t_sock, sk->sk_state); | 55 | rdsdebug("sock %p state_change to %d\n", tc->t_sock, sk->sk_state); |
56 | 56 | ||
57 | switch(sk->sk_state) { | 57 | switch (sk->sk_state) { |
58 | /* ignore connecting sockets as they make progress */ | 58 | /* ignore connecting sockets as they make progress */ |
59 | case TCP_SYN_SENT: | 59 | case TCP_SYN_SENT: |
60 | case TCP_SYN_RECV: | 60 | case TCP_SYN_RECV: |
61 | break; | 61 | break; |
62 | case TCP_ESTABLISHED: | 62 | case TCP_ESTABLISHED: |
63 | rds_connect_path_complete(conn, RDS_CONN_CONNECTING); | 63 | rds_connect_path_complete(conn, RDS_CONN_CONNECTING); |
64 | break; | 64 | break; |
65 | case TCP_CLOSE_WAIT: | 65 | case TCP_CLOSE_WAIT: |
66 | case TCP_CLOSE: | 66 | case TCP_CLOSE: |
67 | rds_conn_drop(conn); | 67 | rds_conn_drop(conn); |
68 | default: | 68 | default: |
69 | break; | 69 | break; |
70 | } | 70 | } |
71 | out: | 71 | out: |
72 | read_unlock_bh(&sk->sk_callback_lock); | 72 | read_unlock_bh(&sk->sk_callback_lock); |
diff --git a/net/rds/tcp_recv.c b/net/rds/tcp_recv.c index c3196f9d070a..6e6a7111a034 100644 --- a/net/rds/tcp_recv.c +++ b/net/rds/tcp_recv.c | |||
@@ -171,7 +171,7 @@ static int rds_tcp_data_recv(read_descriptor_t *desc, struct sk_buff *skb, | |||
171 | while (left) { | 171 | while (left) { |
172 | if (!tinc) { | 172 | if (!tinc) { |
173 | tinc = kmem_cache_alloc(rds_tcp_incoming_slab, | 173 | tinc = kmem_cache_alloc(rds_tcp_incoming_slab, |
174 | arg->gfp); | 174 | arg->gfp); |
175 | if (!tinc) { | 175 | if (!tinc) { |
176 | desc->error = -ENOMEM; | 176 | desc->error = -ENOMEM; |
177 | goto out; | 177 | goto out; |
diff --git a/net/rds/tcp_send.c b/net/rds/tcp_send.c index 22d0f2020a79..618be69c9c3b 100644 --- a/net/rds/tcp_send.c +++ b/net/rds/tcp_send.c | |||
@@ -66,19 +66,19 @@ void rds_tcp_xmit_complete(struct rds_connection *conn) | |||
66 | static int rds_tcp_sendmsg(struct socket *sock, void *data, unsigned int len) | 66 | static int rds_tcp_sendmsg(struct socket *sock, void *data, unsigned int len) |
67 | { | 67 | { |
68 | struct kvec vec = { | 68 | struct kvec vec = { |
69 | .iov_base = data, | 69 | .iov_base = data, |
70 | .iov_len = len, | 70 | .iov_len = len, |
71 | }; | ||
72 | struct msghdr msg = { | ||
73 | .msg_flags = MSG_DONTWAIT | MSG_NOSIGNAL, | ||
71 | }; | 74 | }; |
72 | struct msghdr msg = { | ||
73 | .msg_flags = MSG_DONTWAIT | MSG_NOSIGNAL, | ||
74 | }; | ||
75 | 75 | ||
76 | return kernel_sendmsg(sock, &msg, &vec, 1, vec.iov_len); | 76 | return kernel_sendmsg(sock, &msg, &vec, 1, vec.iov_len); |
77 | } | 77 | } |
78 | 78 | ||
79 | /* the core send_sem serializes this with other xmit and shutdown */ | 79 | /* the core send_sem serializes this with other xmit and shutdown */ |
80 | int rds_tcp_xmit(struct rds_connection *conn, struct rds_message *rm, | 80 | int rds_tcp_xmit(struct rds_connection *conn, struct rds_message *rm, |
81 | unsigned int hdr_off, unsigned int sg, unsigned int off) | 81 | unsigned int hdr_off, unsigned int sg, unsigned int off) |
82 | { | 82 | { |
83 | struct rds_tcp_connection *tc = conn->c_transport_data; | 83 | struct rds_tcp_connection *tc = conn->c_transport_data; |
84 | int done = 0; | 84 | int done = 0; |
@@ -196,7 +196,7 @@ void rds_tcp_write_space(struct sock *sk) | |||
196 | tc->t_last_seen_una = rds_tcp_snd_una(tc); | 196 | tc->t_last_seen_una = rds_tcp_snd_una(tc); |
197 | rds_send_drop_acked(conn, rds_tcp_snd_una(tc), rds_tcp_is_acked); | 197 | rds_send_drop_acked(conn, rds_tcp_snd_una(tc), rds_tcp_is_acked); |
198 | 198 | ||
199 | if ((atomic_read(&sk->sk_wmem_alloc) << 1) <= sk->sk_sndbuf) | 199 | if ((atomic_read(&sk->sk_wmem_alloc) << 1) <= sk->sk_sndbuf) |
200 | queue_delayed_work(rds_wq, &conn->c_send_w, 0); | 200 | queue_delayed_work(rds_wq, &conn->c_send_w, 0); |
201 | 201 | ||
202 | out: | 202 | out: |
diff --git a/net/rds/transport.c b/net/rds/transport.c index f3afd1d60d3c..2ffd3e30c643 100644 --- a/net/rds/transport.c +++ b/net/rds/transport.c | |||
@@ -140,8 +140,7 @@ unsigned int rds_trans_stats_info_copy(struct rds_info_iterator *iter, | |||
140 | rds_info_iter_unmap(iter); | 140 | rds_info_iter_unmap(iter); |
141 | down_read(&rds_trans_sem); | 141 | down_read(&rds_trans_sem); |
142 | 142 | ||
143 | for (i = 0; i < RDS_TRANS_COUNT; i++) | 143 | for (i = 0; i < RDS_TRANS_COUNT; i++) { |
144 | { | ||
145 | trans = transports[i]; | 144 | trans = transports[i]; |
146 | if (!trans || !trans->stats_info_copy) | 145 | if (!trans || !trans->stats_info_copy) |
147 | continue; | 146 | continue; |