summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYueHaibing <yuehaibing@huawei.com>2019-10-23 09:59:41 -0400
committerJoerg Roedel <jroedel@suse.de>2019-10-30 05:16:37 -0400
commit565d454280f85c0a4f204fb160f3d90f8418c080 (patch)
tree08795ffe33ad644abfe0ea648f821fabc59b3eb2
parentd6d5df1db6e9d7f8f76d2911707f7d5877251b02 (diff)
iommu/ipmmu-vmsa: Remove dev_err() on platform_get_irq() failure
platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Joerg Roedel <jroedel@suse.de>
-rw-r--r--drivers/iommu/ipmmu-vmsa.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
index 237103465b82..2639fc718117 100644
--- a/drivers/iommu/ipmmu-vmsa.c
+++ b/drivers/iommu/ipmmu-vmsa.c
@@ -1105,10 +1105,8 @@ static int ipmmu_probe(struct platform_device *pdev)
1105 /* Root devices have mandatory IRQs */ 1105 /* Root devices have mandatory IRQs */
1106 if (ipmmu_is_root(mmu)) { 1106 if (ipmmu_is_root(mmu)) {
1107 irq = platform_get_irq(pdev, 0); 1107 irq = platform_get_irq(pdev, 0);
1108 if (irq < 0) { 1108 if (irq < 0)
1109 dev_err(&pdev->dev, "no IRQ found\n");
1110 return irq; 1109 return irq;
1111 }
1112 1110
1113 ret = devm_request_irq(&pdev->dev, irq, ipmmu_irq, 0, 1111 ret = devm_request_irq(&pdev->dev, irq, ipmmu_irq, 0,
1114 dev_name(&pdev->dev), mmu); 1112 dev_name(&pdev->dev), mmu);