diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-08-10 01:19:11 -0400 |
---|---|---|
committer | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-08-11 17:15:16 -0400 |
commit | 54b13723f765122f3f5f49d07f3e48fa9fcf8c7c (patch) | |
tree | 3b3c180dc7f38540c4ee78b976b1409495067194 | |
parent | 609488bc979f99f805f34e9a32c1e3b71179d10b (diff) |
sh: kernel: disassemble: Mark expected switch fall-throughs
Remove logically dead code and mark switch cases where we are expecting
to fall through.
Fix the following warnings (Building: defconfig sh):
arch/sh/kernel/disassemble.c:478:8: warning: this statement may fall
through [-Wimplicit-fallthrough=]
arch/sh/kernel/disassemble.c:487:8: warning: this statement may fall
through [-Wimplicit-fallthrough=]
arch/sh/kernel/disassemble.c:496:8: warning: this statement may fall
through [-Wimplicit-fallthrough=]
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
-rw-r--r-- | arch/sh/kernel/disassemble.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/arch/sh/kernel/disassemble.c b/arch/sh/kernel/disassemble.c index defebf1a9c8a..845543780cc5 100644 --- a/arch/sh/kernel/disassemble.c +++ b/arch/sh/kernel/disassemble.c | |||
@@ -475,8 +475,6 @@ static void print_sh_insn(u32 memaddr, u16 insn) | |||
475 | printk("dbr"); | 475 | printk("dbr"); |
476 | break; | 476 | break; |
477 | case FD_REG_N: | 477 | case FD_REG_N: |
478 | if (0) | ||
479 | goto d_reg_n; | ||
480 | case F_REG_N: | 478 | case F_REG_N: |
481 | printk("fr%d", rn); | 479 | printk("fr%d", rn); |
482 | break; | 480 | break; |
@@ -488,7 +486,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) | |||
488 | printk("xd%d", rn & ~1); | 486 | printk("xd%d", rn & ~1); |
489 | break; | 487 | break; |
490 | } | 488 | } |
491 | d_reg_n: | 489 | /* else, fall through */ |
492 | case D_REG_N: | 490 | case D_REG_N: |
493 | printk("dr%d", rn); | 491 | printk("dr%d", rn); |
494 | break; | 492 | break; |
@@ -497,6 +495,7 @@ static void print_sh_insn(u32 memaddr, u16 insn) | |||
497 | printk("xd%d", rm & ~1); | 495 | printk("xd%d", rm & ~1); |
498 | break; | 496 | break; |
499 | } | 497 | } |
498 | /* else, fall through */ | ||
500 | case D_REG_M: | 499 | case D_REG_M: |
501 | printk("dr%d", rm); | 500 | printk("dr%d", rm); |
502 | break; | 501 | break; |