summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSean Young <sean@mess.org>2018-02-12 07:20:52 -0500
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2018-02-14 14:14:32 -0500
commit50078a903830796a8a47f26edc4cc10b9061711f (patch)
treee89ac1c3367b243e0c712c4770bfb05e586384d1
parent069edf8a6a42be39b4ec04e56ab7bd18634dc12e (diff)
media: rc: replace IR_dprintk() with dev_dbg in IR decoders
Use dev_dbg() rather than custom debug function. Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
-rw-r--r--drivers/media/rc/ir-jvc-decoder.c14
-rw-r--r--drivers/media/rc/ir-mce_kbd-decoder.c60
-rw-r--r--drivers/media/rc/ir-nec-decoder.c20
-rw-r--r--drivers/media/rc/ir-rc5-decoder.c12
-rw-r--r--drivers/media/rc/ir-rc6-decoder.c26
-rw-r--r--drivers/media/rc/ir-sanyo-decoder.c18
-rw-r--r--drivers/media/rc/ir-sharp-decoder.c17
-rw-r--r--drivers/media/rc/ir-sony-decoder.c14
-rw-r--r--drivers/media/rc/ir-xmp-decoder.c29
9 files changed, 106 insertions, 104 deletions
diff --git a/drivers/media/rc/ir-jvc-decoder.c b/drivers/media/rc/ir-jvc-decoder.c
index c03c776cfa54..8cb68ae43282 100644
--- a/drivers/media/rc/ir-jvc-decoder.c
+++ b/drivers/media/rc/ir-jvc-decoder.c
@@ -56,8 +56,8 @@ static int ir_jvc_decode(struct rc_dev *dev, struct ir_raw_event ev)
56 if (!geq_margin(ev.duration, JVC_UNIT, JVC_UNIT / 2)) 56 if (!geq_margin(ev.duration, JVC_UNIT, JVC_UNIT / 2))
57 goto out; 57 goto out;
58 58
59 IR_dprintk(2, "JVC decode started at state %d (%uus %s)\n", 59 dev_dbg(&dev->dev, "JVC decode started at state %d (%uus %s)\n",
60 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 60 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
61 61
62again: 62again:
63 switch (data->state) { 63 switch (data->state) {
@@ -136,15 +136,15 @@ again:
136 u32 scancode; 136 u32 scancode;
137 scancode = (bitrev8((data->bits >> 8) & 0xff) << 8) | 137 scancode = (bitrev8((data->bits >> 8) & 0xff) << 8) |
138 (bitrev8((data->bits >> 0) & 0xff) << 0); 138 (bitrev8((data->bits >> 0) & 0xff) << 0);
139 IR_dprintk(1, "JVC scancode 0x%04x\n", scancode); 139 dev_dbg(&dev->dev, "JVC scancode 0x%04x\n", scancode);
140 rc_keydown(dev, RC_PROTO_JVC, scancode, data->toggle); 140 rc_keydown(dev, RC_PROTO_JVC, scancode, data->toggle);
141 data->first = false; 141 data->first = false;
142 data->old_bits = data->bits; 142 data->old_bits = data->bits;
143 } else if (data->bits == data->old_bits) { 143 } else if (data->bits == data->old_bits) {
144 IR_dprintk(1, "JVC repeat\n"); 144 dev_dbg(&dev->dev, "JVC repeat\n");
145 rc_repeat(dev); 145 rc_repeat(dev);
146 } else { 146 } else {
147 IR_dprintk(1, "JVC invalid repeat msg\n"); 147 dev_dbg(&dev->dev, "JVC invalid repeat msg\n");
148 break; 148 break;
149 } 149 }
150 150
@@ -164,8 +164,8 @@ again:
164 } 164 }
165 165
166out: 166out:
167 IR_dprintk(1, "JVC decode failed at state %d (%uus %s)\n", 167 dev_dbg(&dev->dev, "JVC decode failed at state %d (%uus %s)\n",
168 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 168 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
169 data->state = STATE_INACTIVE; 169 data->state = STATE_INACTIVE;
170 return -EINVAL; 170 return -EINVAL;
171} 171}
diff --git a/drivers/media/rc/ir-mce_kbd-decoder.c b/drivers/media/rc/ir-mce_kbd-decoder.c
index 2c3df02e05ff..c110984ca671 100644
--- a/drivers/media/rc/ir-mce_kbd-decoder.c
+++ b/drivers/media/rc/ir-mce_kbd-decoder.c
@@ -117,19 +117,19 @@ static unsigned char kbd_keycodes[256] = {
117 117
118static void mce_kbd_rx_timeout(struct timer_list *t) 118static void mce_kbd_rx_timeout(struct timer_list *t)
119{ 119{
120 struct mce_kbd_dec *mce_kbd = from_timer(mce_kbd, t, rx_timeout); 120 struct ir_raw_event_ctrl *raw = from_timer(raw, t, mce_kbd.rx_timeout);
121 int i;
122 unsigned char maskcode; 121 unsigned char maskcode;
122 int i;
123 123
124 IR_dprintk(2, "timer callback clearing all keys\n"); 124 dev_dbg(&raw->dev->dev, "timer callback clearing all keys\n");
125 125
126 for (i = 0; i < 7; i++) { 126 for (i = 0; i < 7; i++) {
127 maskcode = kbd_keycodes[MCIR2_MASK_KEYS_START + i]; 127 maskcode = kbd_keycodes[MCIR2_MASK_KEYS_START + i];
128 input_report_key(mce_kbd->idev, maskcode, 0); 128 input_report_key(raw->mce_kbd.idev, maskcode, 0);
129 } 129 }
130 130
131 for (i = 0; i < MCIR2_MASK_KEYS_START; i++) 131 for (i = 0; i < MCIR2_MASK_KEYS_START; i++)
132 input_report_key(mce_kbd->idev, kbd_keycodes[i], 0); 132 input_report_key(raw->mce_kbd.idev, kbd_keycodes[i], 0);
133} 133}
134 134
135static enum mce_kbd_mode mce_kbd_mode(struct mce_kbd_dec *data) 135static enum mce_kbd_mode mce_kbd_mode(struct mce_kbd_dec *data)
@@ -144,16 +144,16 @@ static enum mce_kbd_mode mce_kbd_mode(struct mce_kbd_dec *data)
144 } 144 }
145} 145}
146 146
147static void ir_mce_kbd_process_keyboard_data(struct input_dev *idev, 147static void ir_mce_kbd_process_keyboard_data(struct rc_dev *dev, u32 scancode)
148 u32 scancode)
149{ 148{
149 struct mce_kbd_dec *data = &dev->raw->mce_kbd;
150 u8 keydata = (scancode >> 8) & 0xff; 150 u8 keydata = (scancode >> 8) & 0xff;
151 u8 shiftmask = scancode & 0xff; 151 u8 shiftmask = scancode & 0xff;
152 unsigned char keycode, maskcode; 152 unsigned char keycode, maskcode;
153 int i, keystate; 153 int i, keystate;
154 154
155 IR_dprintk(1, "keyboard: keydata = 0x%02x, shiftmask = 0x%02x\n", 155 dev_dbg(&dev->dev, "keyboard: keydata = 0x%02x, shiftmask = 0x%02x\n",
156 keydata, shiftmask); 156 keydata, shiftmask);
157 157
158 for (i = 0; i < 7; i++) { 158 for (i = 0; i < 7; i++) {
159 maskcode = kbd_keycodes[MCIR2_MASK_KEYS_START + i]; 159 maskcode = kbd_keycodes[MCIR2_MASK_KEYS_START + i];
@@ -161,20 +161,21 @@ static void ir_mce_kbd_process_keyboard_data(struct input_dev *idev,
161 keystate = 1; 161 keystate = 1;
162 else 162 else
163 keystate = 0; 163 keystate = 0;
164 input_report_key(idev, maskcode, keystate); 164 input_report_key(data->idev, maskcode, keystate);
165 } 165 }
166 166
167 if (keydata) { 167 if (keydata) {
168 keycode = kbd_keycodes[keydata]; 168 keycode = kbd_keycodes[keydata];
169 input_report_key(idev, keycode, 1); 169 input_report_key(data->idev, keycode, 1);
170 } else { 170 } else {
171 for (i = 0; i < MCIR2_MASK_KEYS_START; i++) 171 for (i = 0; i < MCIR2_MASK_KEYS_START; i++)
172 input_report_key(idev, kbd_keycodes[i], 0); 172 input_report_key(data->idev, kbd_keycodes[i], 0);
173 } 173 }
174} 174}
175 175
176static void ir_mce_kbd_process_mouse_data(struct input_dev *idev, u32 scancode) 176static void ir_mce_kbd_process_mouse_data(struct rc_dev *dev, u32 scancode)
177{ 177{
178 struct mce_kbd_dec *data = &dev->raw->mce_kbd;
178 /* raw mouse coordinates */ 179 /* raw mouse coordinates */
179 u8 xdata = (scancode >> 7) & 0x7f; 180 u8 xdata = (scancode >> 7) & 0x7f;
180 u8 ydata = (scancode >> 14) & 0x7f; 181 u8 ydata = (scancode >> 14) & 0x7f;
@@ -193,14 +194,14 @@ static void ir_mce_kbd_process_mouse_data(struct input_dev *idev, u32 scancode)
193 else 194 else
194 y = ydata; 195 y = ydata;
195 196
196 IR_dprintk(1, "mouse: x = %d, y = %d, btns = %s%s\n", 197 dev_dbg(&dev->dev, "mouse: x = %d, y = %d, btns = %s%s\n",
197 x, y, left ? "L" : "", right ? "R" : ""); 198 x, y, left ? "L" : "", right ? "R" : "");
198 199
199 input_report_rel(idev, REL_X, x); 200 input_report_rel(data->idev, REL_X, x);
200 input_report_rel(idev, REL_Y, y); 201 input_report_rel(data->idev, REL_Y, y);
201 202
202 input_report_key(idev, BTN_LEFT, left); 203 input_report_key(data->idev, BTN_LEFT, left);
203 input_report_key(idev, BTN_RIGHT, right); 204 input_report_key(data->idev, BTN_RIGHT, right);
204} 205}
205 206
206/** 207/**
@@ -227,8 +228,8 @@ static int ir_mce_kbd_decode(struct rc_dev *dev, struct ir_raw_event ev)
227 goto out; 228 goto out;
228 229
229again: 230again:
230 IR_dprintk(2, "started at state %i (%uus %s)\n", 231 dev_dbg(&dev->dev, "started at state %i (%uus %s)\n",
231 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 232 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
232 233
233 if (!geq_margin(ev.duration, MCIR2_UNIT, MCIR2_UNIT / 2)) 234 if (!geq_margin(ev.duration, MCIR2_UNIT, MCIR2_UNIT / 2))
234 return 0; 235 return 0;
@@ -280,7 +281,7 @@ again:
280 data->wanted_bits = MCIR2_MOUSE_NBITS; 281 data->wanted_bits = MCIR2_MOUSE_NBITS;
281 break; 282 break;
282 default: 283 default:
283 IR_dprintk(1, "not keyboard or mouse data\n"); 284 dev_dbg(&dev->dev, "not keyboard or mouse data\n");
284 goto out; 285 goto out;
285 } 286 }
286 287
@@ -319,25 +320,26 @@ again:
319 switch (data->wanted_bits) { 320 switch (data->wanted_bits) {
320 case MCIR2_KEYBOARD_NBITS: 321 case MCIR2_KEYBOARD_NBITS:
321 scancode = data->body & 0xffff; 322 scancode = data->body & 0xffff;
322 IR_dprintk(1, "keyboard data 0x%08x\n", data->body); 323 dev_dbg(&dev->dev, "keyboard data 0x%08x\n",
324 data->body);
323 if (dev->timeout) 325 if (dev->timeout)
324 delay = usecs_to_jiffies(dev->timeout / 1000); 326 delay = usecs_to_jiffies(dev->timeout / 1000);
325 else 327 else
326 delay = msecs_to_jiffies(100); 328 delay = msecs_to_jiffies(100);
327 mod_timer(&data->rx_timeout, jiffies + delay); 329 mod_timer(&data->rx_timeout, jiffies + delay);
328 /* Pass data to keyboard buffer parser */ 330 /* Pass data to keyboard buffer parser */
329 ir_mce_kbd_process_keyboard_data(data->idev, scancode); 331 ir_mce_kbd_process_keyboard_data(dev, scancode);
330 lsc.rc_proto = RC_PROTO_MCIR2_KBD; 332 lsc.rc_proto = RC_PROTO_MCIR2_KBD;
331 break; 333 break;
332 case MCIR2_MOUSE_NBITS: 334 case MCIR2_MOUSE_NBITS:
333 scancode = data->body & 0x1fffff; 335 scancode = data->body & 0x1fffff;
334 IR_dprintk(1, "mouse data 0x%06x\n", scancode); 336 dev_dbg(&dev->dev, "mouse data 0x%06x\n", scancode);
335 /* Pass data to mouse buffer parser */ 337 /* Pass data to mouse buffer parser */
336 ir_mce_kbd_process_mouse_data(data->idev, scancode); 338 ir_mce_kbd_process_mouse_data(dev, scancode);
337 lsc.rc_proto = RC_PROTO_MCIR2_MSE; 339 lsc.rc_proto = RC_PROTO_MCIR2_MSE;
338 break; 340 break;
339 default: 341 default:
340 IR_dprintk(1, "not keyboard or mouse data\n"); 342 dev_dbg(&dev->dev, "not keyboard or mouse data\n");
341 goto out; 343 goto out;
342 } 344 }
343 345
@@ -350,8 +352,8 @@ again:
350 } 352 }
351 353
352out: 354out:
353 IR_dprintk(1, "failed at state %i (%uus %s)\n", 355 dev_dbg(&dev->dev, "failed at state %i (%uus %s)\n",
354 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 356 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
355 data->state = STATE_INACTIVE; 357 data->state = STATE_INACTIVE;
356 input_sync(data->idev); 358 input_sync(data->idev);
357 return -EINVAL; 359 return -EINVAL;
diff --git a/drivers/media/rc/ir-nec-decoder.c b/drivers/media/rc/ir-nec-decoder.c
index 31d7bafe7bda..21647b809e6f 100644
--- a/drivers/media/rc/ir-nec-decoder.c
+++ b/drivers/media/rc/ir-nec-decoder.c
@@ -49,8 +49,8 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev)
49 return 0; 49 return 0;
50 } 50 }
51 51
52 IR_dprintk(2, "NEC decode started at state %d (%uus %s)\n", 52 dev_dbg(&dev->dev, "NEC decode started at state %d (%uus %s)\n",
53 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 53 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
54 54
55 switch (data->state) { 55 switch (data->state) {
56 56
@@ -99,13 +99,11 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev)
99 break; 99 break;
100 100
101 if (data->necx_repeat && data->count == NECX_REPEAT_BITS && 101 if (data->necx_repeat && data->count == NECX_REPEAT_BITS &&
102 geq_margin(ev.duration, 102 geq_margin(ev.duration, NEC_TRAILER_SPACE, NEC_UNIT / 2)) {
103 NEC_TRAILER_SPACE, NEC_UNIT / 2)) { 103 dev_dbg(&dev->dev, "Repeat last key\n");
104 IR_dprintk(1, "Repeat last key\n"); 104 rc_repeat(dev);
105 rc_repeat(dev); 105 data->state = STATE_INACTIVE;
106 data->state = STATE_INACTIVE; 106 return 0;
107 return 0;
108
109 } else if (data->count > NECX_REPEAT_BITS) 107 } else if (data->count > NECX_REPEAT_BITS)
110 data->necx_repeat = false; 108 data->necx_repeat = false;
111 109
@@ -164,8 +162,8 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev)
164 return 0; 162 return 0;
165 } 163 }
166 164
167 IR_dprintk(1, "NEC decode failed at count %d state %d (%uus %s)\n", 165 dev_dbg(&dev->dev, "NEC decode failed at count %d state %d (%uus %s)\n",
168 data->count, data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 166 data->count, data->state, TO_US(ev.duration), TO_STR(ev.pulse));
169 data->state = STATE_INACTIVE; 167 data->state = STATE_INACTIVE;
170 return -EINVAL; 168 return -EINVAL;
171} 169}
diff --git a/drivers/media/rc/ir-rc5-decoder.c b/drivers/media/rc/ir-rc5-decoder.c
index 11a28f8772da..74d3b859c3a2 100644
--- a/drivers/media/rc/ir-rc5-decoder.c
+++ b/drivers/media/rc/ir-rc5-decoder.c
@@ -54,8 +54,8 @@ static int ir_rc5_decode(struct rc_dev *dev, struct ir_raw_event ev)
54 goto out; 54 goto out;
55 55
56again: 56again:
57 IR_dprintk(2, "RC5(x/sz) decode started at state %i (%uus %s)\n", 57 dev_dbg(&dev->dev, "RC5(x/sz) decode started at state %i (%uus %s)\n",
58 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 58 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
59 59
60 if (!geq_margin(ev.duration, RC5_UNIT, RC5_UNIT / 2)) 60 if (!geq_margin(ev.duration, RC5_UNIT, RC5_UNIT / 2))
61 return 0; 61 return 0;
@@ -157,8 +157,8 @@ again:
157 } else 157 } else
158 break; 158 break;
159 159
160 IR_dprintk(1, "RC5(x/sz) scancode 0x%06x (p: %u, t: %u)\n", 160 dev_dbg(&dev->dev, "RC5(x/sz) scancode 0x%06x (p: %u, t: %u)\n",
161 scancode, protocol, toggle); 161 scancode, protocol, toggle);
162 162
163 rc_keydown(dev, protocol, scancode, toggle); 163 rc_keydown(dev, protocol, scancode, toggle);
164 data->state = STATE_INACTIVE; 164 data->state = STATE_INACTIVE;
@@ -166,8 +166,8 @@ again:
166 } 166 }
167 167
168out: 168out:
169 IR_dprintk(1, "RC5(x/sz) decode failed at state %i count %d (%uus %s)\n", 169 dev_dbg(&dev->dev, "RC5(x/sz) decode failed at state %i count %d (%uus %s)\n",
170 data->state, data->count, TO_US(ev.duration), TO_STR(ev.pulse)); 170 data->state, data->count, TO_US(ev.duration), TO_STR(ev.pulse));
171 data->state = STATE_INACTIVE; 171 data->state = STATE_INACTIVE;
172 return -EINVAL; 172 return -EINVAL;
173} 173}
diff --git a/drivers/media/rc/ir-rc6-decoder.c b/drivers/media/rc/ir-rc6-decoder.c
index 55bb19bbd4e9..8314da32453f 100644
--- a/drivers/media/rc/ir-rc6-decoder.c
+++ b/drivers/media/rc/ir-rc6-decoder.c
@@ -100,8 +100,8 @@ static int ir_rc6_decode(struct rc_dev *dev, struct ir_raw_event ev)
100 goto out; 100 goto out;
101 101
102again: 102again:
103 IR_dprintk(2, "RC6 decode started at state %i (%uus %s)\n", 103 dev_dbg(&dev->dev, "RC6 decode started at state %i (%uus %s)\n",
104 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 104 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
105 105
106 if (!geq_margin(ev.duration, RC6_UNIT, RC6_UNIT / 2)) 106 if (!geq_margin(ev.duration, RC6_UNIT, RC6_UNIT / 2))
107 return 0; 107 return 0;
@@ -170,7 +170,7 @@ again:
170 break; 170 break;
171 171
172 if (!(data->header & RC6_STARTBIT_MASK)) { 172 if (!(data->header & RC6_STARTBIT_MASK)) {
173 IR_dprintk(1, "RC6 invalid start bit\n"); 173 dev_dbg(&dev->dev, "RC6 invalid start bit\n");
174 break; 174 break;
175 } 175 }
176 176
@@ -187,7 +187,7 @@ again:
187 data->wanted_bits = RC6_6A_NBITS; 187 data->wanted_bits = RC6_6A_NBITS;
188 break; 188 break;
189 default: 189 default:
190 IR_dprintk(1, "RC6 unknown mode\n"); 190 dev_dbg(&dev->dev, "RC6 unknown mode\n");
191 goto out; 191 goto out;
192 } 192 }
193 goto again; 193 goto again;
@@ -230,13 +230,13 @@ again:
230 scancode = data->body; 230 scancode = data->body;
231 toggle = data->toggle; 231 toggle = data->toggle;
232 protocol = RC_PROTO_RC6_0; 232 protocol = RC_PROTO_RC6_0;
233 IR_dprintk(1, "RC6(0) scancode 0x%04x (toggle: %u)\n", 233 dev_dbg(&dev->dev, "RC6(0) scancode 0x%04x (toggle: %u)\n",
234 scancode, toggle); 234 scancode, toggle);
235 break; 235 break;
236 236
237 case RC6_MODE_6A: 237 case RC6_MODE_6A:
238 if (data->count > CHAR_BIT * sizeof data->body) { 238 if (data->count > CHAR_BIT * sizeof data->body) {
239 IR_dprintk(1, "RC6 too many (%u) data bits\n", 239 dev_dbg(&dev->dev, "RC6 too many (%u) data bits\n",
240 data->count); 240 data->count);
241 goto out; 241 goto out;
242 } 242 }
@@ -262,15 +262,15 @@ again:
262 } 262 }
263 break; 263 break;
264 default: 264 default:
265 IR_dprintk(1, "RC6(6A) unsupported length\n"); 265 dev_dbg(&dev->dev, "RC6(6A) unsupported length\n");
266 goto out; 266 goto out;
267 } 267 }
268 268
269 IR_dprintk(1, "RC6(6A) proto 0x%04x, scancode 0x%08x (toggle: %u)\n", 269 dev_dbg(&dev->dev, "RC6(6A) proto 0x%04x, scancode 0x%08x (toggle: %u)\n",
270 protocol, scancode, toggle); 270 protocol, scancode, toggle);
271 break; 271 break;
272 default: 272 default:
273 IR_dprintk(1, "RC6 unknown mode\n"); 273 dev_dbg(&dev->dev, "RC6 unknown mode\n");
274 goto out; 274 goto out;
275 } 275 }
276 276
@@ -280,8 +280,8 @@ again:
280 } 280 }
281 281
282out: 282out:
283 IR_dprintk(1, "RC6 decode failed at state %i (%uus %s)\n", 283 dev_dbg(&dev->dev, "RC6 decode failed at state %i (%uus %s)\n",
284 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 284 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
285 data->state = STATE_INACTIVE; 285 data->state = STATE_INACTIVE;
286 return -EINVAL; 286 return -EINVAL;
287} 287}
diff --git a/drivers/media/rc/ir-sanyo-decoder.c b/drivers/media/rc/ir-sanyo-decoder.c
index ded39cdfc6ef..4efe6db5376a 100644
--- a/drivers/media/rc/ir-sanyo-decoder.c
+++ b/drivers/media/rc/ir-sanyo-decoder.c
@@ -52,14 +52,14 @@ static int ir_sanyo_decode(struct rc_dev *dev, struct ir_raw_event ev)
52 52
53 if (!is_timing_event(ev)) { 53 if (!is_timing_event(ev)) {
54 if (ev.reset) { 54 if (ev.reset) {
55 IR_dprintk(1, "SANYO event reset received. reset to state 0\n"); 55 dev_dbg(&dev->dev, "SANYO event reset received. reset to state 0\n");
56 data->state = STATE_INACTIVE; 56 data->state = STATE_INACTIVE;
57 } 57 }
58 return 0; 58 return 0;
59 } 59 }
60 60
61 IR_dprintk(2, "SANYO decode started at state %d (%uus %s)\n", 61 dev_dbg(&dev->dev, "SANYO decode started at state %d (%uus %s)\n",
62 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 62 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
63 63
64 switch (data->state) { 64 switch (data->state) {
65 65
@@ -102,7 +102,7 @@ static int ir_sanyo_decode(struct rc_dev *dev, struct ir_raw_event ev)
102 102
103 if (!data->count && geq_margin(ev.duration, SANYO_REPEAT_SPACE, SANYO_UNIT / 2)) { 103 if (!data->count && geq_margin(ev.duration, SANYO_REPEAT_SPACE, SANYO_UNIT / 2)) {
104 rc_repeat(dev); 104 rc_repeat(dev);
105 IR_dprintk(1, "SANYO repeat last key\n"); 105 dev_dbg(&dev->dev, "SANYO repeat last key\n");
106 data->state = STATE_INACTIVE; 106 data->state = STATE_INACTIVE;
107 return 0; 107 return 0;
108 } 108 }
@@ -144,21 +144,21 @@ static int ir_sanyo_decode(struct rc_dev *dev, struct ir_raw_event ev)
144 not_command = bitrev8((data->bits >> 0) & 0xff); 144 not_command = bitrev8((data->bits >> 0) & 0xff);
145 145
146 if ((command ^ not_command) != 0xff) { 146 if ((command ^ not_command) != 0xff) {
147 IR_dprintk(1, "SANYO checksum error: received 0x%08Lx\n", 147 dev_dbg(&dev->dev, "SANYO checksum error: received 0x%08llx\n",
148 data->bits); 148 data->bits);
149 data->state = STATE_INACTIVE; 149 data->state = STATE_INACTIVE;
150 return 0; 150 return 0;
151 } 151 }
152 152
153 scancode = address << 8 | command; 153 scancode = address << 8 | command;
154 IR_dprintk(1, "SANYO scancode: 0x%06x\n", scancode); 154 dev_dbg(&dev->dev, "SANYO scancode: 0x%06x\n", scancode);
155 rc_keydown(dev, RC_PROTO_SANYO, scancode, 0); 155 rc_keydown(dev, RC_PROTO_SANYO, scancode, 0);
156 data->state = STATE_INACTIVE; 156 data->state = STATE_INACTIVE;
157 return 0; 157 return 0;
158 } 158 }
159 159
160 IR_dprintk(1, "SANYO decode failed at count %d state %d (%uus %s)\n", 160 dev_dbg(&dev->dev, "SANYO decode failed at count %d state %d (%uus %s)\n",
161 data->count, data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 161 data->count, data->state, TO_US(ev.duration), TO_STR(ev.pulse));
162 data->state = STATE_INACTIVE; 162 data->state = STATE_INACTIVE;
163 return -EINVAL; 163 return -EINVAL;
164} 164}
diff --git a/drivers/media/rc/ir-sharp-decoder.c b/drivers/media/rc/ir-sharp-decoder.c
index df296991906c..6a38c50566a4 100644
--- a/drivers/media/rc/ir-sharp-decoder.c
+++ b/drivers/media/rc/ir-sharp-decoder.c
@@ -54,8 +54,8 @@ static int ir_sharp_decode(struct rc_dev *dev, struct ir_raw_event ev)
54 return 0; 54 return 0;
55 } 55 }
56 56
57 IR_dprintk(2, "Sharp decode started at state %d (%uus %s)\n", 57 dev_dbg(&dev->dev, "Sharp decode started at state %d (%uus %s)\n",
58 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 58 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
59 59
60 switch (data->state) { 60 switch (data->state) {
61 61
@@ -149,9 +149,9 @@ static int ir_sharp_decode(struct rc_dev *dev, struct ir_raw_event ev)
149 msg = (data->bits >> 15) & 0x7fff; 149 msg = (data->bits >> 15) & 0x7fff;
150 echo = data->bits & 0x7fff; 150 echo = data->bits & 0x7fff;
151 if ((msg ^ echo) != 0x3ff) { 151 if ((msg ^ echo) != 0x3ff) {
152 IR_dprintk(1, 152 dev_dbg(&dev->dev,
153 "Sharp checksum error: received 0x%04x, 0x%04x\n", 153 "Sharp checksum error: received 0x%04x, 0x%04x\n",
154 msg, echo); 154 msg, echo);
155 break; 155 break;
156 } 156 }
157 157
@@ -159,16 +159,15 @@ static int ir_sharp_decode(struct rc_dev *dev, struct ir_raw_event ev)
159 command = bitrev8((msg >> 2) & 0xff); 159 command = bitrev8((msg >> 2) & 0xff);
160 160
161 scancode = address << 8 | command; 161 scancode = address << 8 | command;
162 IR_dprintk(1, "Sharp scancode 0x%04x\n", scancode); 162 dev_dbg(&dev->dev, "Sharp scancode 0x%04x\n", scancode);
163 163
164 rc_keydown(dev, RC_PROTO_SHARP, scancode, 0); 164 rc_keydown(dev, RC_PROTO_SHARP, scancode, 0);
165 data->state = STATE_INACTIVE; 165 data->state = STATE_INACTIVE;
166 return 0; 166 return 0;
167 } 167 }
168 168
169 IR_dprintk(1, "Sharp decode failed at count %d state %d (%uus %s)\n", 169 dev_dbg(&dev->dev, "Sharp decode failed at count %d state %d (%uus %s)\n",
170 data->count, data->state, TO_US(ev.duration), 170 data->count, data->state, TO_US(ev.duration), TO_STR(ev.pulse));
171 TO_STR(ev.pulse));
172 data->state = STATE_INACTIVE; 171 data->state = STATE_INACTIVE;
173 return -EINVAL; 172 return -EINVAL;
174} 173}
diff --git a/drivers/media/rc/ir-sony-decoder.c b/drivers/media/rc/ir-sony-decoder.c
index e4bcff21c025..6764ec9de646 100644
--- a/drivers/media/rc/ir-sony-decoder.c
+++ b/drivers/media/rc/ir-sony-decoder.c
@@ -55,8 +55,8 @@ static int ir_sony_decode(struct rc_dev *dev, struct ir_raw_event ev)
55 if (!geq_margin(ev.duration, SONY_UNIT, SONY_UNIT / 2)) 55 if (!geq_margin(ev.duration, SONY_UNIT, SONY_UNIT / 2))
56 goto out; 56 goto out;
57 57
58 IR_dprintk(2, "Sony decode started at state %d (%uus %s)\n", 58 dev_dbg(&dev->dev, "Sony decode started at state %d (%uus %s)\n",
59 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 59 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
60 60
61 switch (data->state) { 61 switch (data->state) {
62 62
@@ -148,19 +148,21 @@ static int ir_sony_decode(struct rc_dev *dev, struct ir_raw_event ev)
148 protocol = RC_PROTO_SONY20; 148 protocol = RC_PROTO_SONY20;
149 break; 149 break;
150 default: 150 default:
151 IR_dprintk(1, "Sony invalid bitcount %u\n", data->count); 151 dev_dbg(&dev->dev, "Sony invalid bitcount %u\n",
152 data->count);
152 goto out; 153 goto out;
153 } 154 }
154 155
155 scancode = device << 16 | subdevice << 8 | function; 156 scancode = device << 16 | subdevice << 8 | function;
156 IR_dprintk(1, "Sony(%u) scancode 0x%05x\n", data->count, scancode); 157 dev_dbg(&dev->dev, "Sony(%u) scancode 0x%05x\n", data->count,
158 scancode);
157 rc_keydown(dev, protocol, scancode, 0); 159 rc_keydown(dev, protocol, scancode, 0);
158 goto finish_state_machine; 160 goto finish_state_machine;
159 } 161 }
160 162
161out: 163out:
162 IR_dprintk(1, "Sony decode failed at state %d (%uus %s)\n", 164 dev_dbg(&dev->dev, "Sony decode failed at state %d (%uus %s)\n",
163 data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 165 data->state, TO_US(ev.duration), TO_STR(ev.pulse));
164 data->state = STATE_INACTIVE; 166 data->state = STATE_INACTIVE;
165 return -EINVAL; 167 return -EINVAL;
166 168
diff --git a/drivers/media/rc/ir-xmp-decoder.c b/drivers/media/rc/ir-xmp-decoder.c
index 712bc6d76e92..58b47af1a763 100644
--- a/drivers/media/rc/ir-xmp-decoder.c
+++ b/drivers/media/rc/ir-xmp-decoder.c
@@ -49,8 +49,8 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)
49 return 0; 49 return 0;
50 } 50 }
51 51
52 IR_dprintk(2, "XMP decode started at state %d %d (%uus %s)\n", 52 dev_dbg(&dev->dev, "XMP decode started at state %d %d (%uus %s)\n",
53 data->state, data->count, TO_US(ev.duration), TO_STR(ev.pulse)); 53 data->state, data->count, TO_US(ev.duration), TO_STR(ev.pulse));
54 54
55 switch (data->state) { 55 switch (data->state) {
56 56
@@ -85,7 +85,7 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)
85 u32 scancode; 85 u32 scancode;
86 86
87 if (data->count != 16) { 87 if (data->count != 16) {
88 IR_dprintk(2, "received TRAILER period at index %d: %u\n", 88 dev_dbg(&dev->dev, "received TRAILER period at index %d: %u\n",
89 data->count, ev.duration); 89 data->count, ev.duration);
90 data->state = STATE_INACTIVE; 90 data->state = STATE_INACTIVE;
91 return -EINVAL; 91 return -EINVAL;
@@ -99,7 +99,8 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)
99 */ 99 */
100 divider = (n[3] - XMP_NIBBLE_PREFIX) / 15 - 2000; 100 divider = (n[3] - XMP_NIBBLE_PREFIX) / 15 - 2000;
101 if (divider < 50) { 101 if (divider < 50) {
102 IR_dprintk(2, "divider to small %d.\n", divider); 102 dev_dbg(&dev->dev, "divider to small %d.\n",
103 divider);
103 data->state = STATE_INACTIVE; 104 data->state = STATE_INACTIVE;
104 return -EINVAL; 105 return -EINVAL;
105 } 106 }
@@ -113,7 +114,7 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)
113 n[12] + n[13] + n[14] + n[15]) % 16; 114 n[12] + n[13] + n[14] + n[15]) % 16;
114 115
115 if (sum1 != 15 || sum2 != 15) { 116 if (sum1 != 15 || sum2 != 15) {
116 IR_dprintk(2, "checksum errors sum1=0x%X sum2=0x%X\n", 117 dev_dbg(&dev->dev, "checksum errors sum1=0x%X sum2=0x%X\n",
117 sum1, sum2); 118 sum1, sum2);
118 data->state = STATE_INACTIVE; 119 data->state = STATE_INACTIVE;
119 return -EINVAL; 120 return -EINVAL;
@@ -127,24 +128,24 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)
127 obc1 = n[12] << 4 | n[13]; 128 obc1 = n[12] << 4 | n[13];
128 obc2 = n[14] << 4 | n[15]; 129 obc2 = n[14] << 4 | n[15];
129 if (subaddr != subaddr2) { 130 if (subaddr != subaddr2) {
130 IR_dprintk(2, "subaddress nibbles mismatch 0x%02X != 0x%02X\n", 131 dev_dbg(&dev->dev, "subaddress nibbles mismatch 0x%02X != 0x%02X\n",
131 subaddr, subaddr2); 132 subaddr, subaddr2);
132 data->state = STATE_INACTIVE; 133 data->state = STATE_INACTIVE;
133 return -EINVAL; 134 return -EINVAL;
134 } 135 }
135 if (oem != 0x44) 136 if (oem != 0x44)
136 IR_dprintk(1, "Warning: OEM nibbles 0x%02X. Expected 0x44\n", 137 dev_dbg(&dev->dev, "Warning: OEM nibbles 0x%02X. Expected 0x44\n",
137 oem); 138 oem);
138 139
139 scancode = addr << 24 | subaddr << 16 | 140 scancode = addr << 24 | subaddr << 16 |
140 obc1 << 8 | obc2; 141 obc1 << 8 | obc2;
141 IR_dprintk(1, "XMP scancode 0x%06x\n", scancode); 142 dev_dbg(&dev->dev, "XMP scancode 0x%06x\n", scancode);
142 143
143 if (toggle == 0) { 144 if (toggle == 0) {
144 rc_keydown(dev, RC_PROTO_XMP, scancode, 0); 145 rc_keydown(dev, RC_PROTO_XMP, scancode, 0);
145 } else { 146 } else {
146 rc_repeat(dev); 147 rc_repeat(dev);
147 IR_dprintk(1, "Repeat last key\n"); 148 dev_dbg(&dev->dev, "Repeat last key\n");
148 } 149 }
149 data->state = STATE_INACTIVE; 150 data->state = STATE_INACTIVE;
150 151
@@ -153,7 +154,7 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)
153 } else if (geq_margin(ev.duration, XMP_HALFFRAME_SPACE, XMP_NIBBLE_PREFIX)) { 154 } else if (geq_margin(ev.duration, XMP_HALFFRAME_SPACE, XMP_NIBBLE_PREFIX)) {
154 /* Expect 8 or 16 nibble pulses. 16 in case of 'final' frame */ 155 /* Expect 8 or 16 nibble pulses. 16 in case of 'final' frame */
155 if (data->count == 16) { 156 if (data->count == 16) {
156 IR_dprintk(2, "received half frame pulse at index %d. Probably a final frame key-up event: %u\n", 157 dev_dbg(&dev->dev, "received half frame pulse at index %d. Probably a final frame key-up event: %u\n",
157 data->count, ev.duration); 158 data->count, ev.duration);
158 /* 159 /*
159 * TODO: for now go back to half frame position 160 * TODO: for now go back to half frame position
@@ -164,7 +165,7 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)
164 } 165 }
165 166
166 else if (data->count != 8) 167 else if (data->count != 8)
167 IR_dprintk(2, "received half frame pulse at index %d: %u\n", 168 dev_dbg(&dev->dev, "received half frame pulse at index %d: %u\n",
168 data->count, ev.duration); 169 data->count, ev.duration);
169 data->state = STATE_LEADER_PULSE; 170 data->state = STATE_LEADER_PULSE;
170 171
@@ -173,7 +174,7 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)
173 } else if (geq_margin(ev.duration, XMP_NIBBLE_PREFIX, XMP_UNIT)) { 174 } else if (geq_margin(ev.duration, XMP_NIBBLE_PREFIX, XMP_UNIT)) {
174 /* store nibble raw data, decode after trailer */ 175 /* store nibble raw data, decode after trailer */
175 if (data->count == 16) { 176 if (data->count == 16) {
176 IR_dprintk(2, "to many pulses (%d) ignoring: %u\n", 177 dev_dbg(&dev->dev, "to many pulses (%d) ignoring: %u\n",
177 data->count, ev.duration); 178 data->count, ev.duration);
178 data->state = STATE_INACTIVE; 179 data->state = STATE_INACTIVE;
179 return -EINVAL; 180 return -EINVAL;
@@ -189,8 +190,8 @@ static int ir_xmp_decode(struct rc_dev *dev, struct ir_raw_event ev)
189 break; 190 break;
190 } 191 }
191 192
192 IR_dprintk(1, "XMP decode failed at count %d state %d (%uus %s)\n", 193 dev_dbg(&dev->dev, "XMP decode failed at count %d state %d (%uus %s)\n",
193 data->count, data->state, TO_US(ev.duration), TO_STR(ev.pulse)); 194 data->count, data->state, TO_US(ev.duration), TO_STR(ev.pulse));
194 data->state = STATE_INACTIVE; 195 data->state = STATE_INACTIVE;
195 return -EINVAL; 196 return -EINVAL;
196} 197}