summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiquel Raynal <miquel.raynal@bootlin.com>2019-07-31 08:21:19 -0400
committerKishon Vijay Abraham I <kishon@ti.com>2019-08-27 02:07:09 -0400
commit4e19a76ec08e52dd3ad43dcd49bbb704a2ff420b (patch)
tree73792757a03cd8b47685e037f9760fb0cce4a57f
parent652488760ea613af0c1207169aeafc9c91203c38 (diff)
phy: mvebu-cp110-comphy: Update comment about powering off all lanes at boot
Now that all COMPHY modes are supported by the driver, update the comment stating that mvebu_comphy_power_off() should be called for each lane. This is still wrong because for compatibility reasons, it might break users running an old firmware (the driver only uses SMC calls for SATA, USB and PCIe configuration, there is no code in Linux to fallback on in these cases. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
-rw-r--r--drivers/phy/marvell/phy-mvebu-cp110-comphy.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c
index 43cd99a69372..847723a5c8f8 100644
--- a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c
+++ b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c
@@ -946,9 +946,11 @@ static int mvebu_comphy_probe(struct platform_device *pdev)
946 phy_set_drvdata(phy, lane); 946 phy_set_drvdata(phy, lane);
947 947
948 /* 948 /*
949 * Once all modes are supported in this driver we should call 949 * All modes are supported in this driver so we could call
950 * mvebu_comphy_power_off(phy) here to avoid relying on the 950 * mvebu_comphy_power_off(phy) here to avoid relying on the
951 * bootloader/firmware configuration. 951 * bootloader/firmware configuration, but for compatibility
952 * reasons we cannot de-configure the COMPHY without being sure
953 * that the firmware is up-to-date and fully-featured.
952 */ 954 */
953 } 955 }
954 956