summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWilly Tarreau <w@1wt.eu>2018-09-08 02:12:21 -0400
committerTakashi Iwai <tiwai@suse.de>2018-09-10 11:18:28 -0400
commit49434c6c575d2008c0abbc93e615019f39e01252 (patch)
tree499e94efd9d2e885a356daa0af63dfaf1ab0a992
parent36f3a6e02c143a7e9e4e143e416371f67bc1fae6 (diff)
ALSA: emu10k1: fix possible info leak to userspace on SNDRV_EMU10K1_IOCTL_INFO
snd_emu10k1_fx8010_ioctl(SNDRV_EMU10K1_IOCTL_INFO) allocates memory using kmalloc() and partially fills it by calling snd_emu10k1_fx8010_info() before returning the resulting structure to userspace, leaving uninitialized holes. Let's just use kzalloc() here. BugLink: http://blog.infosectcbr.com.au/2018/09/linux-kernel-infoleaks.html Signed-off-by: Willy Tarreau <w@1wt.eu> Cc: Jann Horn <jannh@google.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/emu10k1/emufx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c
index 90713741c2dc..6ebe817801ea 100644
--- a/sound/pci/emu10k1/emufx.c
+++ b/sound/pci/emu10k1/emufx.c
@@ -2540,7 +2540,7 @@ static int snd_emu10k1_fx8010_ioctl(struct snd_hwdep * hw, struct file *file, un
2540 emu->support_tlv = 1; 2540 emu->support_tlv = 1;
2541 return put_user(SNDRV_EMU10K1_VERSION, (int __user *)argp); 2541 return put_user(SNDRV_EMU10K1_VERSION, (int __user *)argp);
2542 case SNDRV_EMU10K1_IOCTL_INFO: 2542 case SNDRV_EMU10K1_IOCTL_INFO:
2543 info = kmalloc(sizeof(*info), GFP_KERNEL); 2543 info = kzalloc(sizeof(*info), GFP_KERNEL);
2544 if (!info) 2544 if (!info)
2545 return -ENOMEM; 2545 return -ENOMEM;
2546 snd_emu10k1_fx8010_info(emu, info); 2546 snd_emu10k1_fx8010_info(emu, info);