summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Kicinski <jakub.kicinski@netronome.com>2019-08-06 20:19:23 -0400
committerDaniel Borkmann <daniel@iogearbox.net>2019-08-09 11:38:53 -0400
commit3c7be384fe6da0d7b1d6fc0ad6b4a33edb73aad5 (patch)
treeff6a09b0cb3b5fbe8a05bd28c6f86fb505a79f7b
parentb3e78adcbf991a4e8b2ebb23c9889e968ec76c5f (diff)
tools: bpftool: add error message on pin failure
No error message is currently printed if the pin syscall itself fails. It got lost in the loadall refactoring. Fixes: 77380998d91d ("bpftool: add loadall command") Reported-by: Andy Lutomirski <luto@kernel.org> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> Acked-by: Andrii Nakryiko <andriin@fb.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
-rw-r--r--tools/bpf/bpftool/common.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c
index c52a6ffb8949..6a71324be628 100644
--- a/tools/bpf/bpftool/common.c
+++ b/tools/bpf/bpftool/common.c
@@ -204,7 +204,11 @@ int do_pin_fd(int fd, const char *name)
204 if (err) 204 if (err)
205 return err; 205 return err;
206 206
207 return bpf_obj_pin(fd, name); 207 err = bpf_obj_pin(fd, name);
208 if (err)
209 p_err("can't pin the object (%s): %s", name, strerror(errno));
210
211 return err;
208} 212}
209 213
210int do_pin_any(int argc, char **argv, int (*get_fd_by_id)(__u32)) 214int do_pin_any(int argc, char **argv, int (*get_fd_by_id)(__u32))