summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Layton <jeff.layton@primarydata.com>2015-01-22 08:19:32 -0500
committerJ. Bruce Fields <bfields@redhat.com>2015-01-23 10:29:12 -0500
commit3c5199143bc4b35f472c5c2534026d74821e2044 (patch)
tree1751acaacbd83ddc906e7b3b2c15f218b4ae4f4d
parentbbc7f33ac6ff6f48709ce892aa906ddb68b34517 (diff)
sunrpc/lockd: fix references to the BKL
The BKL is completely out of the picture in the lockd and sunrpc code these days. Update the antiquated comments that refer to it. Signed-off-by: Jeff Layton <jlayton@primarydata.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
-rw-r--r--fs/lockd/svclock.c4
-rw-r--r--include/linux/sunrpc/svc.h2
-rw-r--r--net/sunrpc/svc.c4
-rw-r--r--net/sunrpc/svc_xprt.c3
4 files changed, 6 insertions, 7 deletions
diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c
index 56598742dde4..5581e020644b 100644
--- a/fs/lockd/svclock.c
+++ b/fs/lockd/svclock.c
@@ -57,8 +57,8 @@ static DEFINE_SPINLOCK(nlm_blocked_lock);
57static const char *nlmdbg_cookie2a(const struct nlm_cookie *cookie) 57static const char *nlmdbg_cookie2a(const struct nlm_cookie *cookie)
58{ 58{
59 /* 59 /*
60 * We can get away with a static buffer because we're only 60 * We can get away with a static buffer because this is only called
61 * called with BKL held. 61 * from lockd, which is single-threaded.
62 */ 62 */
63 static char buf[2*NLM_MAXCOOKIELEN+1]; 63 static char buf[2*NLM_MAXCOOKIELEN+1];
64 unsigned int i, len = sizeof(buf); 64 unsigned int i, len = sizeof(buf);
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index 6f22cfeef5e3..fae6fb947fc8 100644
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -110,7 +110,7 @@ struct svc_serv {
110 * We use sv_nrthreads as a reference count. svc_destroy() drops 110 * We use sv_nrthreads as a reference count. svc_destroy() drops
111 * this refcount, so we need to bump it up around operations that 111 * this refcount, so we need to bump it up around operations that
112 * change the number of threads. Horrible, but there it is. 112 * change the number of threads. Horrible, but there it is.
113 * Should be called with the BKL held. 113 * Should be called with the "service mutex" held.
114 */ 114 */
115static inline void svc_get(struct svc_serv *serv) 115static inline void svc_get(struct svc_serv *serv)
116{ 116{
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 91eaef1844c8..78974e4d9ad2 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -768,8 +768,8 @@ svc_set_num_threads(struct svc_serv *serv, struct svc_pool *pool, int nrservs)
768EXPORT_SYMBOL_GPL(svc_set_num_threads); 768EXPORT_SYMBOL_GPL(svc_set_num_threads);
769 769
770/* 770/*
771 * Called from a server thread as it's exiting. Caller must hold the BKL or 771 * Called from a server thread as it's exiting. Caller must hold the "service
772 * the "service mutex", whichever is appropriate for the service. 772 * mutex" for the service.
773 */ 773 */
774void 774void
775svc_exit_thread(struct svc_rqst *rqstp) 775svc_exit_thread(struct svc_rqst *rqstp)
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index c69358b3cf7f..163ac45c3639 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -42,7 +42,7 @@ static LIST_HEAD(svc_xprt_class_list);
42 * svc_pool->sp_lock protects most of the fields of that pool. 42 * svc_pool->sp_lock protects most of the fields of that pool.
43 * svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt. 43 * svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt.
44 * when both need to be taken (rare), svc_serv->sv_lock is first. 44 * when both need to be taken (rare), svc_serv->sv_lock is first.
45 * BKL protects svc_serv->sv_nrthread. 45 * The "service mutex" protects svc_serv->sv_nrthread.
46 * svc_sock->sk_lock protects the svc_sock->sk_deferred list 46 * svc_sock->sk_lock protects the svc_sock->sk_deferred list
47 * and the ->sk_info_authunix cache. 47 * and the ->sk_info_authunix cache.
48 * 48 *
@@ -67,7 +67,6 @@ static LIST_HEAD(svc_xprt_class_list);
67 * that no other thread will be using the transport or will 67 * that no other thread will be using the transport or will
68 * try to set XPT_DEAD. 68 * try to set XPT_DEAD.
69 */ 69 */
70
71int svc_reg_xprt_class(struct svc_xprt_class *xcl) 70int svc_reg_xprt_class(struct svc_xprt_class *xcl)
72{ 71{
73 struct svc_xprt_class *cl; 72 struct svc_xprt_class *cl;