diff options
author | Stephen Boyd <swboyd@chromium.org> | 2019-07-30 14:15:08 -0400 |
---|---|---|
committer | Paul Burton <paul.burton@mips.com> | 2019-08-26 06:26:04 -0400 |
commit | 322e577b02ab096aaf630caae93f18e1e67b775f (patch) | |
tree | 2430b8716bdb471deeb95ecbd9bdcf7e0deff39c | |
parent | b4742e6682d5809ddf4d0a63cb57e629e815ec63 (diff) |
MIPS: Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.
// <smpl>
@@
expression ret;
struct platform_device *E;
@@
ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);
if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>
While we're here, remove braces on if statements that only have one
statement (manually).
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@mips.com>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-mips@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: linux-kernel@vger.kernel.org
-rw-r--r-- | arch/mips/ralink/timer.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c index 0ad8ff2e4f6e..652424d8ed51 100644 --- a/arch/mips/ralink/timer.c +++ b/arch/mips/ralink/timer.c | |||
@@ -106,10 +106,8 @@ static int rt_timer_probe(struct platform_device *pdev) | |||
106 | } | 106 | } |
107 | 107 | ||
108 | rt->irq = platform_get_irq(pdev, 0); | 108 | rt->irq = platform_get_irq(pdev, 0); |
109 | if (rt->irq < 0) { | 109 | if (rt->irq < 0) |
110 | dev_err(&pdev->dev, "failed to load irq\n"); | ||
111 | return rt->irq; | 110 | return rt->irq; |
112 | } | ||
113 | 111 | ||
114 | rt->membase = devm_ioremap_resource(&pdev->dev, res); | 112 | rt->membase = devm_ioremap_resource(&pdev->dev, res); |
115 | if (IS_ERR(rt->membase)) | 113 | if (IS_ERR(rt->membase)) |