diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2019-06-03 11:23:58 -0400 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2019-06-03 11:23:58 -0400 |
commit | 318759b4737c3b3789e2fd64d539f437d52386f5 (patch) | |
tree | 80b6b478a49501eb8923a747159288eef8b79d97 | |
parent | a89e9b8abf82725e4ac96100e07c8104dbe8a240 (diff) |
signal/x86: Move tsk inside of CONFIG_MEMORY_FAILURE in do_sigbus
Stephen Rothwell <sfr@canb.auug.org.au> reported:
> After merging the userns tree, today's linux-next build (i386 defconfig)
> produced this warning:
>
> arch/x86/mm/fault.c: In function 'do_sigbus':
> arch/x86/mm/fault.c:1017:22: warning: unused variable 'tsk' [-Wunused-variable]
> struct task_struct *tsk = current;
> ^~~
>
> Introduced by commit
>
> 351b6825b3a9 ("signal: Explicitly call force_sig_fault on current")
>
> The remaining used of "tsk" are protected by CONFIG_MEMORY_FAILURE.
So do the obvious thing and move tsk inside of CONFIG_MEMORY_FAILURE
to prevent introducing new warnings into the build.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
-rw-r--r-- | arch/x86/mm/fault.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index 46ac96aa7c81..fb4e39c4e0a9 100644 --- a/arch/x86/mm/fault.c +++ b/arch/x86/mm/fault.c | |||
@@ -1014,8 +1014,6 @@ static void | |||
1014 | do_sigbus(struct pt_regs *regs, unsigned long error_code, unsigned long address, | 1014 | do_sigbus(struct pt_regs *regs, unsigned long error_code, unsigned long address, |
1015 | vm_fault_t fault) | 1015 | vm_fault_t fault) |
1016 | { | 1016 | { |
1017 | struct task_struct *tsk = current; | ||
1018 | |||
1019 | /* Kernel mode? Handle exceptions or die: */ | 1017 | /* Kernel mode? Handle exceptions or die: */ |
1020 | if (!(error_code & X86_PF_USER)) { | 1018 | if (!(error_code & X86_PF_USER)) { |
1021 | no_context(regs, error_code, address, SIGBUS, BUS_ADRERR); | 1019 | no_context(regs, error_code, address, SIGBUS, BUS_ADRERR); |
@@ -1030,6 +1028,7 @@ do_sigbus(struct pt_regs *regs, unsigned long error_code, unsigned long address, | |||
1030 | 1028 | ||
1031 | #ifdef CONFIG_MEMORY_FAILURE | 1029 | #ifdef CONFIG_MEMORY_FAILURE |
1032 | if (fault & (VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE)) { | 1030 | if (fault & (VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE)) { |
1031 | struct task_struct *tsk = current; | ||
1033 | unsigned lsb = 0; | 1032 | unsigned lsb = 0; |
1034 | 1033 | ||
1035 | pr_err( | 1034 | pr_err( |