diff options
author | Enric Balletbo i Serra <enric.balletbo@collabora.com> | 2019-09-02 05:53:04 -0400 |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2019-09-02 06:33:35 -0400 |
commit | 2fa2b980e3fe187a0b916bfe6bd5822889b44d5e (patch) | |
tree | 5513cc965b02425a885a9ad6b7b18672c4c1d4f1 | |
parent | 459aedb9a5d4b92e4aee343ee8ee5aeca8e1d93a (diff) |
mfd / platform: cros_ec: Rename config to a better name
The cros-ec-dev is a multifunction device that now doesn't implement any
chardev communication interface. MFD_CROS_EC_CHARDEV doesn't look
a good name to describe that device and can cause confusion. Hence
rename it to CROS_EC_DEV.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Tested-by: Gwendal Grignou <gwendal@chromium.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
-rw-r--r-- | drivers/mfd/Kconfig | 17 | ||||
-rw-r--r-- | drivers/mfd/Makefile | 2 | ||||
-rw-r--r-- | drivers/platform/chrome/Kconfig | 32 |
3 files changed, 32 insertions, 19 deletions
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index d79882b608cf..c5c5ff308881 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig | |||
@@ -211,15 +211,18 @@ config MFD_AXP20X_RSB | |||
211 | components like regulators or the PEK (Power Enable Key) under the | 211 | components like regulators or the PEK (Power Enable Key) under the |
212 | corresponding menus. | 212 | corresponding menus. |
213 | 213 | ||
214 | config MFD_CROS_EC_CHARDEV | 214 | config MFD_CROS_EC_DEV |
215 | tristate "Chrome OS Embedded Controller userspace device interface" | 215 | tristate "ChromeOS Embedded Controller multifunction device" |
216 | depends on CROS_EC | ||
217 | select MFD_CORE | 216 | select MFD_CORE |
218 | ---help--- | 217 | depends on CROS_EC |
219 | This driver adds support to talk with the ChromeOS EC from userspace. | 218 | default CROS_EC |
219 | help | ||
220 | Select this to get support for ChromeOS Embedded Controller | ||
221 | sub-devices. This driver will instantiate additional drivers such | ||
222 | as RTC, USBPD, etc. but you have to select the individual drivers. | ||
220 | 223 | ||
221 | If you have a supported Chromebook, choose Y or M here. | 224 | To compile this driver as a module, choose M here: the module will be |
222 | The module will be called cros_ec_dev. | 225 | called cros-ec-dev. |
223 | 226 | ||
224 | config MFD_MADERA | 227 | config MFD_MADERA |
225 | tristate "Cirrus Logic Madera codecs" | 228 | tristate "Cirrus Logic Madera codecs" |
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 59ab5bf51b65..0c0a848e62df 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile | |||
@@ -13,7 +13,7 @@ obj-$(CONFIG_MFD_ASIC3) += asic3.o tmio_core.o | |||
13 | obj-$(CONFIG_ARCH_BCM2835) += bcm2835-pm.o | 13 | obj-$(CONFIG_ARCH_BCM2835) += bcm2835-pm.o |
14 | obj-$(CONFIG_MFD_BCM590XX) += bcm590xx.o | 14 | obj-$(CONFIG_MFD_BCM590XX) += bcm590xx.o |
15 | obj-$(CONFIG_MFD_BD9571MWV) += bd9571mwv.o | 15 | obj-$(CONFIG_MFD_BD9571MWV) += bd9571mwv.o |
16 | obj-$(CONFIG_MFD_CROS_EC_CHARDEV) += cros_ec_dev.o | 16 | obj-$(CONFIG_MFD_CROS_EC_DEV) += cros_ec_dev.o |
17 | obj-$(CONFIG_MFD_EXYNOS_LPASS) += exynos-lpass.o | 17 | obj-$(CONFIG_MFD_EXYNOS_LPASS) += exynos-lpass.o |
18 | 18 | ||
19 | obj-$(CONFIG_HTC_PASIC3) += htc-pasic3.o | 19 | obj-$(CONFIG_HTC_PASIC3) += htc-pasic3.o |
diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig index bd3524bd6b37..ee5f08ea57b6 100644 --- a/drivers/platform/chrome/Kconfig +++ b/drivers/platform/chrome/Kconfig | |||
@@ -3,6 +3,16 @@ | |||
3 | # Platform support for Chrome OS hardware (Chromebooks and Chromeboxes) | 3 | # Platform support for Chrome OS hardware (Chromebooks and Chromeboxes) |
4 | # | 4 | # |
5 | 5 | ||
6 | config MFD_CROS_EC | ||
7 | tristate "Platform support for Chrome hardware (transitional)" | ||
8 | select CHROME_PLATFORMS | ||
9 | select CROS_EC | ||
10 | select CONFIG_MFD_CROS_EC_DEV | ||
11 | depends on X86 || ARM || ARM64 || COMPILE_TEST | ||
12 | help | ||
13 | This is a transitional Kconfig option and will be removed after | ||
14 | everyone enables the parts individually. | ||
15 | |||
6 | menuconfig CHROME_PLATFORMS | 16 | menuconfig CHROME_PLATFORMS |
7 | bool "Platform support for Chrome hardware" | 17 | bool "Platform support for Chrome hardware" |
8 | depends on X86 || ARM || ARM64 || COMPILE_TEST | 18 | depends on X86 || ARM || ARM64 || COMPILE_TEST |
@@ -87,7 +97,7 @@ config CROS_EC_RPMSG | |||
87 | 97 | ||
88 | config CROS_EC_ISHTP | 98 | config CROS_EC_ISHTP |
89 | tristate "ChromeOS Embedded Controller (ISHTP)" | 99 | tristate "ChromeOS Embedded Controller (ISHTP)" |
90 | depends on MFD_CROS_EC | 100 | depends on CROS_EC |
91 | depends on INTEL_ISH_HID | 101 | depends on INTEL_ISH_HID |
92 | help | 102 | help |
93 | If you say Y here, you get support for talking to the ChromeOS EC | 103 | If you say Y here, you get support for talking to the ChromeOS EC |
@@ -138,8 +148,8 @@ config CROS_KBD_LED_BACKLIGHT | |||
138 | 148 | ||
139 | config CROS_EC_CHARDEV | 149 | config CROS_EC_CHARDEV |
140 | tristate "ChromeOS EC miscdevice" | 150 | tristate "ChromeOS EC miscdevice" |
141 | depends on MFD_CROS_EC_CHARDEV | 151 | depends on MFD_CROS_EC_DEV |
142 | default MFD_CROS_EC_CHARDEV | 152 | default MFD_CROS_EC_DEV |
143 | help | 153 | help |
144 | This driver adds file operations support to talk with the | 154 | This driver adds file operations support to talk with the |
145 | ChromeOS EC from userspace via a character device. | 155 | ChromeOS EC from userspace via a character device. |
@@ -149,8 +159,8 @@ config CROS_EC_CHARDEV | |||
149 | 159 | ||
150 | config CROS_EC_LIGHTBAR | 160 | config CROS_EC_LIGHTBAR |
151 | tristate "Chromebook Pixel's lightbar support" | 161 | tristate "Chromebook Pixel's lightbar support" |
152 | depends on MFD_CROS_EC_CHARDEV | 162 | depends on MFD_CROS_EC_DEV |
153 | default MFD_CROS_EC_CHARDEV | 163 | default MFD_CROS_EC_DEV |
154 | help | 164 | help |
155 | This option exposes the Chromebook Pixel's lightbar to | 165 | This option exposes the Chromebook Pixel's lightbar to |
156 | userspace. | 166 | userspace. |
@@ -160,8 +170,8 @@ config CROS_EC_LIGHTBAR | |||
160 | 170 | ||
161 | config CROS_EC_VBC | 171 | config CROS_EC_VBC |
162 | tristate "ChromeOS EC vboot context support" | 172 | tristate "ChromeOS EC vboot context support" |
163 | depends on MFD_CROS_EC_CHARDEV && OF | 173 | depends on MFD_CROS_EC_DEV && OF |
164 | default MFD_CROS_EC_CHARDEV | 174 | default MFD_CROS_EC_DEV |
165 | help | 175 | help |
166 | This option exposes the ChromeOS EC vboot context nvram to | 176 | This option exposes the ChromeOS EC vboot context nvram to |
167 | userspace. | 177 | userspace. |
@@ -171,8 +181,8 @@ config CROS_EC_VBC | |||
171 | 181 | ||
172 | config CROS_EC_DEBUGFS | 182 | config CROS_EC_DEBUGFS |
173 | tristate "Export ChromeOS EC internals in DebugFS" | 183 | tristate "Export ChromeOS EC internals in DebugFS" |
174 | depends on MFD_CROS_EC_CHARDEV && DEBUG_FS | 184 | depends on MFD_CROS_EC_DEV && DEBUG_FS |
175 | default MFD_CROS_EC_CHARDEV | 185 | default MFD_CROS_EC_DEV |
176 | help | 186 | help |
177 | This option exposes the ChromeOS EC device internals to | 187 | This option exposes the ChromeOS EC device internals to |
178 | userspace. | 188 | userspace. |
@@ -182,8 +192,8 @@ config CROS_EC_DEBUGFS | |||
182 | 192 | ||
183 | config CROS_EC_SYSFS | 193 | config CROS_EC_SYSFS |
184 | tristate "ChromeOS EC control and information through sysfs" | 194 | tristate "ChromeOS EC control and information through sysfs" |
185 | depends on MFD_CROS_EC_CHARDEV && SYSFS | 195 | depends on MFD_CROS_EC_DEV && SYSFS |
186 | default MFD_CROS_EC_CHARDEV | 196 | default MFD_CROS_EC_DEV |
187 | help | 197 | help |
188 | This option exposes some sysfs attributes to control and get | 198 | This option exposes some sysfs attributes to control and get |
189 | information from ChromeOS EC. | 199 | information from ChromeOS EC. |