diff options
author | Gustavo A. R. Silva <garsilva@embeddedor.com> | 2017-11-08 12:17:39 -0500 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2017-12-04 20:32:52 -0500 |
commit | 2c7982364e05abaa709c0b69dd94c8b389f8ae13 (patch) | |
tree | 449887f9e24873a8b7f0439d2a59b9bea05842bf | |
parent | f35cb48ef8d18afbd262db800508b8512f6c09ad (diff) |
scsi: ppa: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114988
Addresses-Coverity-ID: 114989
Addresses-Coverity-ID: 114990
Addresses-Coverity-ID: 114991
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r-- | drivers/scsi/ppa.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.c index 7be5823ab036..ee86a0c62dbf 100644 --- a/drivers/scsi/ppa.c +++ b/drivers/scsi/ppa.c | |||
@@ -724,6 +724,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd) | |||
724 | return 0; | 724 | return 0; |
725 | } | 725 | } |
726 | cmd->SCp.phase++; | 726 | cmd->SCp.phase++; |
727 | /* fall through */ | ||
727 | 728 | ||
728 | case 3: /* Phase 3 - Ready to accept a command */ | 729 | case 3: /* Phase 3 - Ready to accept a command */ |
729 | w_ctr(ppb, 0x0c); | 730 | w_ctr(ppb, 0x0c); |
@@ -733,6 +734,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd) | |||
733 | if (!ppa_send_command(cmd)) | 734 | if (!ppa_send_command(cmd)) |
734 | return 0; | 735 | return 0; |
735 | cmd->SCp.phase++; | 736 | cmd->SCp.phase++; |
737 | /* fall through */ | ||
736 | 738 | ||
737 | case 4: /* Phase 4 - Setup scatter/gather buffers */ | 739 | case 4: /* Phase 4 - Setup scatter/gather buffers */ |
738 | if (scsi_bufflen(cmd)) { | 740 | if (scsi_bufflen(cmd)) { |
@@ -746,6 +748,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd) | |||
746 | } | 748 | } |
747 | cmd->SCp.buffers_residual = scsi_sg_count(cmd) - 1; | 749 | cmd->SCp.buffers_residual = scsi_sg_count(cmd) - 1; |
748 | cmd->SCp.phase++; | 750 | cmd->SCp.phase++; |
751 | /* fall through */ | ||
749 | 752 | ||
750 | case 5: /* Phase 5 - Data transfer stage */ | 753 | case 5: /* Phase 5 - Data transfer stage */ |
751 | w_ctr(ppb, 0x0c); | 754 | w_ctr(ppb, 0x0c); |
@@ -758,6 +761,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd) | |||
758 | if (retv == 0) | 761 | if (retv == 0) |
759 | return 1; | 762 | return 1; |
760 | cmd->SCp.phase++; | 763 | cmd->SCp.phase++; |
764 | /* fall through */ | ||
761 | 765 | ||
762 | case 6: /* Phase 6 - Read status/message */ | 766 | case 6: /* Phase 6 - Read status/message */ |
763 | cmd->result = DID_OK << 16; | 767 | cmd->result = DID_OK << 16; |