summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafał Miłecki <rafal@milecki.pl>2017-10-12 04:21:25 -0400
committerDavid S. Miller <davem@davemloft.net>2017-10-13 01:59:38 -0400
commit2355a6546a053b1c16ebefd6ce1f0cccc00e1da5 (patch)
tree3d041989b24f4ab300c3ac24ad4b04d06e2e5447
parent32c10bbfe914c76d8802be33c97b59be9582df1b (diff)
net: phy: broadcom: support new device flag for setting master mode
Some of Broadcom's PHYs run by default in slave mode with Automatic Slave/Master configuration disabled. It stops them from working properly with some devices. So far it has been verified for BCM54210E and BCM50212E which don't work well with Intel's I217-LM and I218-LM: http://ark.intel.com/products/60019/Intel-Ethernet-Connection-I217-LM http://ark.intel.com/products/71307/Intel-Ethernet-Connection-I218-LM I was told there is massive ping loss. This commit adds support for a new flag which can be set by an ethernet driver to fixup PHY setup. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/phy/broadcom.c6
-rw-r--r--include/linux/brcmphy.h1
2 files changed, 7 insertions, 0 deletions
diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index 1e9ad30a35c8..d7ed69deabfb 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -43,6 +43,12 @@ static int bcm54210e_config_init(struct phy_device *phydev)
43 val &= ~BCM54810_SHD_CLK_CTL_GTXCLK_EN; 43 val &= ~BCM54810_SHD_CLK_CTL_GTXCLK_EN;
44 bcm_phy_write_shadow(phydev, BCM54810_SHD_CLK_CTL, val); 44 bcm_phy_write_shadow(phydev, BCM54810_SHD_CLK_CTL, val);
45 45
46 if (phydev->dev_flags & PHY_BRCM_EN_MASTER_MODE) {
47 val = phy_read(phydev, MII_CTRL1000);
48 val |= CTL1000_AS_MASTER | CTL1000_ENABLE_MASTER;
49 phy_write(phydev, MII_CTRL1000, val);
50 }
51
46 return 0; 52 return 0;
47} 53}
48 54
diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h
index abcda9b458ab..9ac9e3e3d1e5 100644
--- a/include/linux/brcmphy.h
+++ b/include/linux/brcmphy.h
@@ -63,6 +63,7 @@
63#define PHY_BRCM_EXT_IBND_TX_ENABLE 0x00002000 63#define PHY_BRCM_EXT_IBND_TX_ENABLE 0x00002000
64#define PHY_BRCM_CLEAR_RGMII_MODE 0x00004000 64#define PHY_BRCM_CLEAR_RGMII_MODE 0x00004000
65#define PHY_BRCM_DIS_TXCRXC_NOENRGY 0x00008000 65#define PHY_BRCM_DIS_TXCRXC_NOENRGY 0x00008000
66#define PHY_BRCM_EN_MASTER_MODE 0x00010000
66 67
67/* Broadcom BCM7xxx specific workarounds */ 68/* Broadcom BCM7xxx specific workarounds */
68#define PHY_BRCM_7XXX_REV(x) (((x) >> 8) & 0xff) 69#define PHY_BRCM_7XXX_REV(x) (((x) >> 8) & 0xff)