summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYue Hu <huyue2@yulong.com>2019-05-13 20:18:14 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2019-05-14 12:47:47 -0400
commit1df3a339074e31db95c4790ea9236874b13ccd87 (patch)
tree808458ab7f0be8a13d34a4c259fd68d4c2e20a10
parent113b7dfd827175977ea71cc4a29c1ac24acb9fce (diff)
mm/cma.c: fix crash on CMA allocation if bitmap allocation fails
f022d8cb7ec7 ("mm: cma: Don't crash on allocation if CMA area can't be activated") fixes the crash issue when activation fails via setting cma->count as 0, same logic exists if bitmap allocation fails. Link: http://lkml.kernel.org/r/20190325081309.6004-1-zbestahu@gmail.com Signed-off-by: Yue Hu <huyue2@yulong.com> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Laura Abbott <labbott@redhat.com> Cc: Mike Rapoport <rppt@linux.vnet.ibm.com> Cc: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--mm/cma.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/mm/cma.c b/mm/cma.c
index d72a02fb7759..5e36d7418031 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -106,8 +106,10 @@ static int __init cma_activate_area(struct cma *cma)
106 106
107 cma->bitmap = kzalloc(bitmap_size, GFP_KERNEL); 107 cma->bitmap = kzalloc(bitmap_size, GFP_KERNEL);
108 108
109 if (!cma->bitmap) 109 if (!cma->bitmap) {
110 cma->count = 0;
110 return -ENOMEM; 111 return -ENOMEM;
112 }
111 113
112 WARN_ON_ONCE(!pfn_valid(pfn)); 114 WARN_ON_ONCE(!pfn_valid(pfn));
113 zone = page_zone(pfn_to_page(pfn)); 115 zone = page_zone(pfn_to_page(pfn));