summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>2019-06-27 21:48:53 -0400
committerMark Brown <broonie@kernel.org>2019-06-28 10:17:56 -0400
commit1dd2e91b08d52eced666e1c1343960ac6374c6a7 (patch)
tree3cf8985160e16f6c29032f6c4d24806bfea6e9ef
parentff9194baa91b854ffcec538d4565ecdde40eaf3d (diff)
ASoC: tegra: tegra_rt5677: consider CPU-Platform possibility
commit d035d13b2277 ("ASoC: tegra: tegra_rt5677: don't select unnecessary Platform") Current ALSA SoC avoid to add duplicate component to rtd, and this driver was selecting CPU component as Platform component. Thus, above patch removed Platform settings from this driver, because it assumed these are same component. But, some CPU driver is using generic DMAEngine, in such case, both CPU component and Platform component will have same of_node/name. In other words, there are some components which are different but have same of_node/name. In such case, Card driver definitely need to select Platform even though it is same as CPU. It is depends on CPU driver, but is difficult to know it from Card driver. This patch reverts above patch. Fixes: commit d035d13b2277 ("ASoC: tegra: tegra_rt5677: don't select unnecessary Platform") Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/tegra/tegra_rt5677.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/sound/soc/tegra/tegra_rt5677.c b/sound/soc/tegra/tegra_rt5677.c
index 738bdf876b13..81cb6cc6236e 100644
--- a/sound/soc/tegra/tegra_rt5677.c
+++ b/sound/soc/tegra/tegra_rt5677.c
@@ -160,7 +160,8 @@ static int tegra_rt5677_asoc_init(struct snd_soc_pcm_runtime *rtd)
160 160
161SND_SOC_DAILINK_DEFS(pcm, 161SND_SOC_DAILINK_DEFS(pcm,
162 DAILINK_COMP_ARRAY(COMP_EMPTY()), 162 DAILINK_COMP_ARRAY(COMP_EMPTY()),
163 DAILINK_COMP_ARRAY(COMP_CODEC(NULL, "rt5677-aif1"))); 163 DAILINK_COMP_ARRAY(COMP_CODEC(NULL, "rt5677-aif1")),
164 DAILINK_COMP_ARRAY(COMP_EMPTY()));
164 165
165static struct snd_soc_dai_link tegra_rt5677_dai = { 166static struct snd_soc_dai_link tegra_rt5677_dai = {
166 .name = "RT5677", 167 .name = "RT5677",
@@ -259,6 +260,7 @@ static int tegra_rt5677_probe(struct platform_device *pdev)
259 ret = -EINVAL; 260 ret = -EINVAL;
260 goto err_put_codec_of_node; 261 goto err_put_codec_of_node;
261 } 262 }
263 tegra_rt5677_dai.platforms->of_node = tegra_rt5677_dai.cpus->of_node;
262 264
263 ret = tegra_asoc_utils_init(&machine->util_data, &pdev->dev); 265 ret = tegra_asoc_utils_init(&machine->util_data, &pdev->dev);
264 if (ret) 266 if (ret)
@@ -278,6 +280,7 @@ err_fini_utils:
278err_put_cpu_of_node: 280err_put_cpu_of_node:
279 of_node_put(tegra_rt5677_dai.cpus->of_node); 281 of_node_put(tegra_rt5677_dai.cpus->of_node);
280 tegra_rt5677_dai.cpus->of_node = NULL; 282 tegra_rt5677_dai.cpus->of_node = NULL;
283 tegra_rt5677_dai.platforms->of_node = NULL;
281err_put_codec_of_node: 284err_put_codec_of_node:
282 of_node_put(tegra_rt5677_dai.codecs->of_node); 285 of_node_put(tegra_rt5677_dai.codecs->of_node);
283 tegra_rt5677_dai.codecs->of_node = NULL; 286 tegra_rt5677_dai.codecs->of_node = NULL;
@@ -294,6 +297,7 @@ static int tegra_rt5677_remove(struct platform_device *pdev)
294 297
295 tegra_asoc_utils_fini(&machine->util_data); 298 tegra_asoc_utils_fini(&machine->util_data);
296 299
300 tegra_rt5677_dai.platforms->of_node = NULL;
297 of_node_put(tegra_rt5677_dai.codecs->of_node); 301 of_node_put(tegra_rt5677_dai.codecs->of_node);
298 tegra_rt5677_dai.codecs->of_node = NULL; 302 tegra_rt5677_dai.codecs->of_node = NULL;
299 of_node_put(tegra_rt5677_dai.cpus->of_node); 303 of_node_put(tegra_rt5677_dai.cpus->of_node);