diff options
| author | Arseny Solokha <asolokha@kb.kras.ru> | 2019-07-16 07:12:36 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-07-25 08:39:51 -0400 |
| commit | 1b5621832f9bd9899370ea6928462cd02ebe7dc0 (patch) | |
| tree | 84728d2985e094a2554088ab20c9aaee09f4d4ec | |
| parent | 10b0f1c227ed8236555318cb26933881b7e907f9 (diff) | |
eeprom: make older eeprom drivers select NVMEM_SYSFS
misc/eeprom/{at24,at25,eeprom_93xx46} drivers all register their
corresponding devices in the nvmem framework in compat mode which requires
nvmem sysfs interface to be present. The latter, however, has been split
out from nvmem under a separate Kconfig in commit ae0c2d725512 ("nvmem:
core: add NVMEM_SYSFS Kconfig"). As a result, probing certain I2C-attached
EEPROMs now fails with
at24: probe of 0-0050 failed with error -38
because of a stub implementation of nvmem_sysfs_setup_compat()
in drivers/nvmem/nvmem.h. Update the nvmem dependency for these drivers
so they could load again:
at24 0-0050: 32768 byte 24c256 EEPROM, writable, 64 bytes/write
Cc: Adrian Bunk <bunk@kernel.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: stable@vger.kernel.org # v5.2+
Signed-off-by: Arseny Solokha <asolokha@kb.kras.ru>
Link: https://lore.kernel.org/r/20190716111236.27803-1-asolokha@kb.kras.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/misc/eeprom/Kconfig | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig index f88094719552..f2abe27010ef 100644 --- a/drivers/misc/eeprom/Kconfig +++ b/drivers/misc/eeprom/Kconfig | |||
| @@ -5,6 +5,7 @@ config EEPROM_AT24 | |||
| 5 | tristate "I2C EEPROMs / RAMs / ROMs from most vendors" | 5 | tristate "I2C EEPROMs / RAMs / ROMs from most vendors" |
| 6 | depends on I2C && SYSFS | 6 | depends on I2C && SYSFS |
| 7 | select NVMEM | 7 | select NVMEM |
| 8 | select NVMEM_SYSFS | ||
| 8 | select REGMAP_I2C | 9 | select REGMAP_I2C |
| 9 | help | 10 | help |
| 10 | Enable this driver to get read/write support to most I2C EEPROMs | 11 | Enable this driver to get read/write support to most I2C EEPROMs |
| @@ -34,6 +35,7 @@ config EEPROM_AT25 | |||
| 34 | tristate "SPI EEPROMs from most vendors" | 35 | tristate "SPI EEPROMs from most vendors" |
| 35 | depends on SPI && SYSFS | 36 | depends on SPI && SYSFS |
| 36 | select NVMEM | 37 | select NVMEM |
| 38 | select NVMEM_SYSFS | ||
| 37 | help | 39 | help |
| 38 | Enable this driver to get read/write support to most SPI EEPROMs, | 40 | Enable this driver to get read/write support to most SPI EEPROMs, |
| 39 | after you configure the board init code to know about each eeprom | 41 | after you configure the board init code to know about each eeprom |
| @@ -80,6 +82,7 @@ config EEPROM_93XX46 | |||
| 80 | depends on SPI && SYSFS | 82 | depends on SPI && SYSFS |
| 81 | select REGMAP | 83 | select REGMAP |
| 82 | select NVMEM | 84 | select NVMEM |
| 85 | select NVMEM_SYSFS | ||
| 83 | help | 86 | help |
| 84 | Driver for the microwire EEPROM chipsets 93xx46x. The driver | 87 | Driver for the microwire EEPROM chipsets 93xx46x. The driver |
| 85 | supports both read and write commands and also the command to | 88 | supports both read and write commands and also the command to |