summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2019-09-03 08:40:18 -0400
committerJan Kara <jack@suse.cz>2019-09-04 12:19:43 -0400
commit18c2433cb8af4938bee01a766a2389f80e73d4ae (patch)
tree1f5e54fe7f3c2955a502f93a57ad172fb7ac0c9a
parent8b47ea6c21cbf169c4c41ad6de1ac12fba5ddd8e (diff)
ext2: Delete an unnecessary check before brelse()
The brelse() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Link: https://lore.kernel.org/r/51dea296-2207-ebc0-bac3-13f3e5c3b235@web.de Signed-off-by: Jan Kara <jack@suse.cz>
-rw-r--r--fs/ext2/super.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 44eb6e7eb492..f4d5c624c4dc 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -162,8 +162,7 @@ static void ext2_put_super (struct super_block * sb)
162 } 162 }
163 db_count = sbi->s_gdb_count; 163 db_count = sbi->s_gdb_count;
164 for (i = 0; i < db_count; i++) 164 for (i = 0; i < db_count; i++)
165 if (sbi->s_group_desc[i]) 165 brelse(sbi->s_group_desc[i]);
166 brelse (sbi->s_group_desc[i]);
167 kfree(sbi->s_group_desc); 166 kfree(sbi->s_group_desc);
168 kfree(sbi->s_debts); 167 kfree(sbi->s_debts);
169 percpu_counter_destroy(&sbi->s_freeblocks_counter); 168 percpu_counter_destroy(&sbi->s_freeblocks_counter);