diff options
author | Don Brace <don.brace@microsemi.com> | 2019-07-24 18:08:12 -0400 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2019-07-30 12:40:36 -0400 |
commit | 18a56d699d174f3ac41f2ea86e1ca21f98b01d8f (patch) | |
tree | 97f09911e7d2225d4c299a3dddb570963d3d1d32 | |
parent | eeebce1862970653cdf5c01e98bc669edd8f529a (diff) |
scsi: hpsa: remove printing internal cdb on tag collision
Remove racy printing of internal commands. Completion thread can be
cleaning up the command in parallel.
Reviewed-by: Bader Ali - Saleh <bader.alisaleh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r-- | drivers/scsi/hpsa.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 89e71ebc5964..bba099e53266 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c | |||
@@ -6091,8 +6091,6 @@ static struct CommandList *cmd_tagged_alloc(struct ctlr_info *h, | |||
6091 | if (idx != h->last_collision_tag) { /* Print once per tag */ | 6091 | if (idx != h->last_collision_tag) { /* Print once per tag */ |
6092 | dev_warn(&h->pdev->dev, | 6092 | dev_warn(&h->pdev->dev, |
6093 | "%s: tag collision (tag=%d)\n", __func__, idx); | 6093 | "%s: tag collision (tag=%d)\n", __func__, idx); |
6094 | if (c->scsi_cmd != NULL) | ||
6095 | scsi_print_command(c->scsi_cmd); | ||
6096 | if (scmd) | 6094 | if (scmd) |
6097 | scsi_print_command(scmd); | 6095 | scsi_print_command(scmd); |
6098 | h->last_collision_tag = idx; | 6096 | h->last_collision_tag = idx; |