summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Boyd <swboyd@chromium.org>2019-01-10 16:02:52 -0500
committerMark Brown <broonie@kernel.org>2019-01-14 07:22:11 -0500
commit0357a3daada3236da59be5d692f02ae07e2a145e (patch)
tree0bf834c62f674f0eeaccb357a892e78023798424
parent74fa750e63a9b962583213d161a79991188c6ec8 (diff)
spi: spi-geni-qcom: Don't initialize completion for normal message
We only use this completion when we're doing something that isn't a message transfer. For example, changing CS or aborting/canceling a command. All of those situations properly reinitialize the completion before sending the GENI the special command to change CS or cancel, etc. Given that, let's remove the initialization here. Cc: Girish Mahadevan <girishm@codeaurora.org> Cc: Dilip Kota <dkota@codeaurora.org> Cc: Alok Chauhan <alokc@codeaurora.org> Cc: Douglas Anderson <dianders@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--drivers/spi/spi-geni-qcom.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c
index fdb7cb88fb56..c3e9464027d4 100644
--- a/drivers/spi/spi-geni-qcom.c
+++ b/drivers/spi/spi-geni-qcom.c
@@ -233,7 +233,6 @@ static int spi_geni_prepare_message(struct spi_master *spi,
233 struct geni_se *se = &mas->se; 233 struct geni_se *se = &mas->se;
234 234
235 geni_se_select_mode(se, GENI_SE_FIFO); 235 geni_se_select_mode(se, GENI_SE_FIFO);
236 reinit_completion(&mas->xfer_done);
237 ret = setup_fifo_params(spi_msg->spi, spi); 236 ret = setup_fifo_params(spi_msg->spi, spi);
238 if (ret) 237 if (ret)
239 dev_err(mas->dev, "Couldn't select mode %d\n", ret); 238 dev_err(mas->dev, "Couldn't select mode %d\n", ret);