diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-08-21 00:12:35 -0400 |
---|---|---|
committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-10-05 02:29:49 -0400 |
commit | 01bb25156d856e3efb887a273c03f8ba66f8fb0f (patch) | |
tree | 71976e8c95a470988b6751d4a00ed88ec514edd3 | |
parent | a9bbe79fd5cb2411d69ab8a2e94bb701ca45e133 (diff) |
video/logo: do not generate unneeded logo C files
Currently, all the logo C files are generated irrespective of the
CONFIG options. Adding them to extra-y is wrong. What we need to do
here is to add them to 'targets' so that if_changed works properly.
Files listed in 'targets' are cleaned, so clean-files is unneeded.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
-rw-r--r-- | drivers/video/logo/Makefile | 21 |
1 files changed, 2 insertions, 19 deletions
diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile index 10b75ce3ce09..16f60c1e1766 100644 --- a/drivers/video/logo/Makefile +++ b/drivers/video/logo/Makefile | |||
@@ -18,23 +18,6 @@ obj-$(CONFIG_SPU_BASE) += logo_spe_clut224.o | |||
18 | 18 | ||
19 | # How to generate logo's | 19 | # How to generate logo's |
20 | 20 | ||
21 | # Use logo-cfiles to retrieve list of .c files to be built | ||
22 | logo-cfiles = $(notdir $(patsubst %.$(2), %.c, \ | ||
23 | $(wildcard $(srctree)/$(src)/*$(1).$(2)))) | ||
24 | |||
25 | |||
26 | # Mono logos | ||
27 | extra-y += $(call logo-cfiles,_mono,pbm) | ||
28 | |||
29 | # VGA16 logos | ||
30 | extra-y += $(call logo-cfiles,_vga16,ppm) | ||
31 | |||
32 | # 224 Logos | ||
33 | extra-y += $(call logo-cfiles,_clut224,ppm) | ||
34 | |||
35 | # Gray 256 | ||
36 | extra-y += $(call logo-cfiles,_gray256,pgm) | ||
37 | |||
38 | pnmtologo := scripts/pnmtologo | 21 | pnmtologo := scripts/pnmtologo |
39 | 22 | ||
40 | # Create commands like "pnmtologo -t mono -n logo_mac_mono -o ..." | 23 | # Create commands like "pnmtologo -t mono -n logo_mac_mono -o ..." |
@@ -55,5 +38,5 @@ $(obj)/%_clut224.c: $(src)/%_clut224.ppm $(pnmtologo) FORCE | |||
55 | $(obj)/%_gray256.c: $(src)/%_gray256.pgm $(pnmtologo) FORCE | 38 | $(obj)/%_gray256.c: $(src)/%_gray256.pgm $(pnmtologo) FORCE |
56 | $(call if_changed,logo) | 39 | $(call if_changed,logo) |
57 | 40 | ||
58 | # Files generated that shall be removed upon make clean | 41 | # generated C files |
59 | clean-files := *_mono.c *_vga16.c *_clut224.c *_gray256.c | 42 | targets += *_mono.c *_vga16.c *_clut224.c *_gray256.c |