diff options
author | Andreas Gruenbacher <agruen@linbit.com> | 2011-07-22 07:53:19 -0400 |
---|---|---|
committer | Philipp Reisner <philipp.reisner@linbit.com> | 2014-02-17 10:46:48 -0500 |
commit | f44d0436db1ea02f2a08bec40a854550a93e90a8 (patch) | |
tree | 1954be419a9cca3cada1636d96cb93868b5eafbd | |
parent | 6bbf53ca6269353c1d8174678b15aa4288a9cdb0 (diff) |
drbd: Define the size of res_opts->cpu_mask in a single place
Signed-off-by: Andreas Gruenbacher <agruen@linbit.com>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
-rw-r--r-- | drivers/block/drbd/drbd_main.c | 3 | ||||
-rw-r--r-- | include/linux/drbd.h | 2 | ||||
-rw-r--r-- | include/linux/drbd_genl.h | 2 |
3 files changed, 4 insertions, 3 deletions
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index e07446e19c74..59a58e896cf5 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c | |||
@@ -2503,8 +2503,7 @@ int set_resource_options(struct drbd_resource *resource, struct res_opts *res_op | |||
2503 | 2503 | ||
2504 | /* silently ignore cpu mask on UP kernel */ | 2504 | /* silently ignore cpu mask on UP kernel */ |
2505 | if (nr_cpu_ids > 1 && res_opts->cpu_mask[0] != 0) { | 2505 | if (nr_cpu_ids > 1 && res_opts->cpu_mask[0] != 0) { |
2506 | /* FIXME: Get rid of constant 32 here */ | 2506 | err = bitmap_parse(res_opts->cpu_mask, DRBD_CPU_MASK_SIZE, |
2507 | err = bitmap_parse(res_opts->cpu_mask, 32, | ||
2508 | cpumask_bits(new_cpu_mask), nr_cpu_ids); | 2507 | cpumask_bits(new_cpu_mask), nr_cpu_ids); |
2509 | if (err) { | 2508 | if (err) { |
2510 | drbd_warn(resource, "bitmap_parse() failed with %d\n", err); | 2509 | drbd_warn(resource, "bitmap_parse() failed with %d\n", err); |
diff --git a/include/linux/drbd.h b/include/linux/drbd.h index de7d74ab3de6..6f60136da873 100644 --- a/include/linux/drbd.h +++ b/include/linux/drbd.h | |||
@@ -382,4 +382,6 @@ enum drbd_timeout_flag { | |||
382 | #define DRBD_MD_INDEX_FLEX_EXT -2 | 382 | #define DRBD_MD_INDEX_FLEX_EXT -2 |
383 | #define DRBD_MD_INDEX_FLEX_INT -3 | 383 | #define DRBD_MD_INDEX_FLEX_INT -3 |
384 | 384 | ||
385 | #define DRBD_CPU_MASK_SIZE 32 | ||
386 | |||
385 | #endif | 387 | #endif |
diff --git a/include/linux/drbd_genl.h b/include/linux/drbd_genl.h index b14a2e899fea..4193f5f2636c 100644 --- a/include/linux/drbd_genl.h +++ b/include/linux/drbd_genl.h | |||
@@ -135,7 +135,7 @@ GENL_struct(DRBD_NLA_DISK_CONF, 3, disk_conf, | |||
135 | ) | 135 | ) |
136 | 136 | ||
137 | GENL_struct(DRBD_NLA_RESOURCE_OPTS, 4, res_opts, | 137 | GENL_struct(DRBD_NLA_RESOURCE_OPTS, 4, res_opts, |
138 | __str_field_def(1, DRBD_GENLA_F_MANDATORY, cpu_mask, 32) | 138 | __str_field_def(1, DRBD_GENLA_F_MANDATORY, cpu_mask, DRBD_CPU_MASK_SIZE) |
139 | __u32_field_def(2, DRBD_GENLA_F_MANDATORY, on_no_data, DRBD_ON_NO_DATA_DEF) | 139 | __u32_field_def(2, DRBD_GENLA_F_MANDATORY, on_no_data, DRBD_ON_NO_DATA_DEF) |
140 | ) | 140 | ) |
141 | 141 | ||