summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOded Gabbay <oded.gabbay@gmail.com>2019-03-02 04:43:12 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-03-02 06:03:56 -0500
commitdbbe358b13706d86d1945a010f5d2a34b8c81d06 (patch)
tree5dd2148b96436374a5520a948c945297409a38eb
parent99f63620b484b421c480d5048d8ab88a0bacb7ac (diff)
habanalabs: use %px instead of %p in error print
When parsing the address of an internal command buffer, the driver prints an error if the buffer's address is not in the range of the device's DRAM or SRAM memory address space. Use %px to print the real address that the user gave the driver and not a hashed value, so the user will get a clue regarding the origin of his error. Note that if the print occurs, the pointer that is printed is a user's virtual address and not some kind of physical address. Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/misc/habanalabs/goya/goya.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
index c4f3ec1e9d8b..238dd57c541b 100644
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -4293,7 +4293,7 @@ static int goya_parse_cb_no_ext_quque(struct hl_device *hdev,
4293 return 0; 4293 return 0;
4294 4294
4295 dev_err(hdev->dev, 4295 dev_err(hdev->dev,
4296 "Internal CB address %p + 0x%x is not in SRAM nor in DRAM\n", 4296 "Internal CB address %px + 0x%x is not in SRAM nor in DRAM\n",
4297 parser->user_cb, parser->user_cb_size); 4297 parser->user_cb, parser->user_cb_size);
4298 4298
4299 return -EFAULT; 4299 return -EFAULT;