summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJia-Ju Bai <baijiaju1990@gmail.com>2018-07-27 05:09:13 -0400
committerMartin K. Petersen <martin.petersen@oracle.com>2018-07-30 23:17:53 -0400
commitd6aec1ca7c7c69e5b83b2cb24a57e7860d15507f (patch)
tree98ce6107026b9fc47858e69b47fcb385ae56968e
parent508385001c09ee648c46f3d2bf5584e366007fd7 (diff)
scsi: a100u2w: Replace mdelay() with msleep()
wait_chip_ready() and wait_firmware_ready() are never called in atomic context. They call mdelay() to busy wait which is not necessary. mdelay() can be replaced with msleep(). This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r--drivers/scsi/a100u2w.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
index b2942ec3d455..23b17621b6d2 100644
--- a/drivers/scsi/a100u2w.c
+++ b/drivers/scsi/a100u2w.c
@@ -143,7 +143,7 @@ static u8 wait_chip_ready(struct orc_host * host)
143 for (i = 0; i < 10; i++) { /* Wait 1 second for report timeout */ 143 for (i = 0; i < 10; i++) { /* Wait 1 second for report timeout */
144 if (inb(host->base + ORC_HCTRL) & HOSTSTOP) /* Wait HOSTSTOP set */ 144 if (inb(host->base + ORC_HCTRL) & HOSTSTOP) /* Wait HOSTSTOP set */
145 return 1; 145 return 1;
146 mdelay(100); 146 msleep(100);
147 } 147 }
148 return 0; 148 return 0;
149} 149}
@@ -155,7 +155,7 @@ static u8 wait_firmware_ready(struct orc_host * host)
155 for (i = 0; i < 10; i++) { /* Wait 1 second for report timeout */ 155 for (i = 0; i < 10; i++) { /* Wait 1 second for report timeout */
156 if (inb(host->base + ORC_HSTUS) & RREADY) /* Wait READY set */ 156 if (inb(host->base + ORC_HSTUS) & RREADY) /* Wait READY set */
157 return 1; 157 return 1;
158 mdelay(100); /* wait 100ms before try again */ 158 msleep(100); /* wait 100ms before try again */
159 } 159 }
160 return 0; 160 return 0;
161} 161}