PCI: dwc: dra7xx: Push request_irq() call to the bottom of probe

Currently devm_request_irq() is being called before base, PCI fields of
dra7xx_pcie structure are populated. It is called even before
pm_runtime_enable() and pm_runtime_get_sync() are called. This will lead
to exceptions if in case an interrupt is triggered before the all of the
above are done. Hence push the devm_request_irq() call to the end of the
probe.

Signed-off-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

1 files changed, 7 insertions, 7 deletions

diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index 07c45ec07662..7c9ed6a6675c 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -410,13 +410,6 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
                 return -EINVAL;
         }
 
-        ret = devm_request_irq(dev, irq, dra7xx_pcie_irq_handler,
-                               IRQF_SHARED, "dra7xx-pcie-main", dra7xx);
-        if (ret) {
-                dev_err(dev, "failed to request irq\n");
-                return ret;
-        }
-
         res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf");
         base = devm_ioremap_nocache(dev, res->start, resource_size(res));
         if (!base)
@@ -478,6 +471,13 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
         if (ret < 0)
                 goto err_gpio;
 
+        ret = devm_request_irq(dev, irq, dra7xx_pcie_irq_handler,
+                               IRQF_SHARED, "dra7xx-pcie-main", dra7xx);
+        if (ret) {
+                dev_err(dev, "failed to request irq\n");
+                goto err_gpio;
+        }
+
         return 0;
 
 err_gpio: