summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjorn Helgaas <bhelgaas@google.com>2019-09-23 17:10:31 -0400
committerBjorn Helgaas <bhelgaas@google.com>2019-09-23 17:10:31 -0400
commitc5048a73b4770304699cb15e3ffcb97acab685f7 (patch)
treeb6e8a8676251a835fcf1f0f927d0182e6ff63be2
parentcdc7e184abb338dfe24624e90b09d366f0dcfad5 (diff)
parent55507aea58824578610eb0cb5c250a0c997987c9 (diff)
Merge branch 'pci/trivial'
- Fix typos and whitespace errors (Bjorn Helgaas, Krzysztof Wilczynski) - Remove unnecessary "return" statements (Krzysztof Wilczynski) - Correct of_irq_parse_pci() function documentation (Lubomir Rintel) * pci/trivial: PCI: Remove unnecessary returns PCI: OF: Correct of_irq_parse_pci() documentation PCI: Fix typos and whitespace errors
-rw-r--r--Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt2
-rw-r--r--Documentation/devicetree/bindings/pci/pci-armada8k.txt2
-rw-r--r--drivers/pci/Kconfig2
-rw-r--r--drivers/pci/controller/pcie-mediatek.c2
-rw-r--r--drivers/pci/hotplug/cpci_hotplug_core.c1
-rw-r--r--drivers/pci/hotplug/cpqphp_core.c1
-rw-r--r--drivers/pci/hotplug/cpqphp_ctrl.c4
-rw-r--r--drivers/pci/hotplug/cpqphp_nvram.h5
-rw-r--r--drivers/pci/hotplug/rpadlpar_core.c1
-rw-r--r--drivers/pci/hotplug/rpaphp_core.c1
-rw-r--r--drivers/pci/of.c2
-rw-r--r--drivers/pci/vc.c1
-rw-r--r--include/linux/pci.h4
13 files changed, 7 insertions, 21 deletions
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
index a7f5f5afa0e6..de4b2baf91e8 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
@@ -50,7 +50,7 @@ Additional required properties for imx7d-pcie and imx8mq-pcie:
50- power-domains: Must be set to a phandle pointing to PCIE_PHY power domain 50- power-domains: Must be set to a phandle pointing to PCIE_PHY power domain
51- resets: Must contain phandles to PCIe-related reset lines exposed by SRC 51- resets: Must contain phandles to PCIe-related reset lines exposed by SRC
52 IP block 52 IP block
53- reset-names: Must contain the following entires: 53- reset-names: Must contain the following entries:
54 - "pciephy" 54 - "pciephy"
55 - "apps" 55 - "apps"
56 - "turnoff" 56 - "turnoff"
diff --git a/Documentation/devicetree/bindings/pci/pci-armada8k.txt b/Documentation/devicetree/bindings/pci/pci-armada8k.txt
index 9e3fc15e1af8..1aaa09254001 100644
--- a/Documentation/devicetree/bindings/pci/pci-armada8k.txt
+++ b/Documentation/devicetree/bindings/pci/pci-armada8k.txt
@@ -11,7 +11,7 @@ Required properties:
11- reg-names: 11- reg-names:
12 - "ctrl" for the control register region 12 - "ctrl" for the control register region
13 - "config" for the config space region 13 - "config" for the config space region
14- interrupts: Interrupt specifier for the PCIe controler 14- interrupts: Interrupt specifier for the PCIe controller
15- clocks: reference to the PCIe controller clocks 15- clocks: reference to the PCIe controller clocks
16- clock-names: mandatory if there is a second clock, in this case the 16- clock-names: mandatory if there is a second clock, in this case the
17 name must be "core" for the first clock and "reg" for the second 17 name must be "core" for the first clock and "reg" for the second
diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index 232042722261..a5017b66bd9d 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -170,7 +170,7 @@ config PCI_P2PDMA
170 170
171 Many PCIe root complexes do not support P2P transactions and 171 Many PCIe root complexes do not support P2P transactions and
172 it's hard to tell which support it at all, so at this time, 172 it's hard to tell which support it at all, so at this time,
173 P2P DMA transations must be between devices behind the same root 173 P2P DMA transactions must be between devices behind the same root
174 port. 174 port.
175 175
176 If unsure, say N. 176 If unsure, say N.
diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c
index 3eaa7081ab2a..626a7c352dfd 100644
--- a/drivers/pci/controller/pcie-mediatek.c
+++ b/drivers/pci/controller/pcie-mediatek.c
@@ -635,8 +635,6 @@ static void mtk_pcie_intr_handler(struct irq_desc *desc)
635 } 635 }
636 636
637 chained_irq_exit(irqchip, desc); 637 chained_irq_exit(irqchip, desc);
638
639 return;
640} 638}
641 639
642static int mtk_pcie_setup_irq(struct mtk_pcie_port *port, 640static int mtk_pcie_setup_irq(struct mtk_pcie_port *port,
diff --git a/drivers/pci/hotplug/cpci_hotplug_core.c b/drivers/pci/hotplug/cpci_hotplug_core.c
index 603eadf3d965..d0559d2faf50 100644
--- a/drivers/pci/hotplug/cpci_hotplug_core.c
+++ b/drivers/pci/hotplug/cpci_hotplug_core.c
@@ -563,7 +563,6 @@ cleanup_slots(void)
563 } 563 }
564cleanup_null: 564cleanup_null:
565 up_write(&list_rwsem); 565 up_write(&list_rwsem);
566 return;
567} 566}
568 567
569int 568int
diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
index 16bbb183695a..b8aacb41a83c 100644
--- a/drivers/pci/hotplug/cpqphp_core.c
+++ b/drivers/pci/hotplug/cpqphp_core.c
@@ -173,7 +173,6 @@ static void pci_print_IRQ_route(void)
173 dbg("%d %d %d %d\n", tbus, tdevice >> 3, tdevice & 0x7, tslot); 173 dbg("%d %d %d %d\n", tbus, tdevice >> 3, tdevice & 0x7, tslot);
174 174
175 } 175 }
176 return;
177} 176}
178 177
179 178
diff --git a/drivers/pci/hotplug/cpqphp_ctrl.c b/drivers/pci/hotplug/cpqphp_ctrl.c
index b7f4e1f099d9..68de958a9be8 100644
--- a/drivers/pci/hotplug/cpqphp_ctrl.c
+++ b/drivers/pci/hotplug/cpqphp_ctrl.c
@@ -1872,8 +1872,6 @@ static void interrupt_event_handler(struct controller *ctrl)
1872 } 1872 }
1873 } /* End of FOR loop */ 1873 } /* End of FOR loop */
1874 } 1874 }
1875
1876 return;
1877} 1875}
1878 1876
1879 1877
@@ -1943,8 +1941,6 @@ void cpqhp_pushbutton_thread(struct timer_list *t)
1943 1941
1944 p_slot->state = STATIC_STATE; 1942 p_slot->state = STATIC_STATE;
1945 } 1943 }
1946
1947 return;
1948} 1944}
1949 1945
1950 1946
diff --git a/drivers/pci/hotplug/cpqphp_nvram.h b/drivers/pci/hotplug/cpqphp_nvram.h
index 918ff8dbfe62..70e879b6a23f 100644
--- a/drivers/pci/hotplug/cpqphp_nvram.h
+++ b/drivers/pci/hotplug/cpqphp_nvram.h
@@ -16,10 +16,7 @@
16 16
17#ifndef CONFIG_HOTPLUG_PCI_COMPAQ_NVRAM 17#ifndef CONFIG_HOTPLUG_PCI_COMPAQ_NVRAM
18 18
19static inline void compaq_nvram_init(void __iomem *rom_start) 19static inline void compaq_nvram_init(void __iomem *rom_start) { }
20{
21 return;
22}
23 20
24static inline int compaq_nvram_load(void __iomem *rom_start, struct controller *ctrl) 21static inline int compaq_nvram_load(void __iomem *rom_start, struct controller *ctrl)
25{ 22{
diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
index 182f9e3443ee..977946e4e613 100644
--- a/drivers/pci/hotplug/rpadlpar_core.c
+++ b/drivers/pci/hotplug/rpadlpar_core.c
@@ -473,7 +473,6 @@ int __init rpadlpar_io_init(void)
473void rpadlpar_io_exit(void) 473void rpadlpar_io_exit(void)
474{ 474{
475 dlpar_sysfs_exit(); 475 dlpar_sysfs_exit();
476 return;
477} 476}
478 477
479module_init(rpadlpar_io_init); 478module_init(rpadlpar_io_init);
diff --git a/drivers/pci/hotplug/rpaphp_core.c b/drivers/pci/hotplug/rpaphp_core.c
index bcd5d357ca23..d34a3baf9b3a 100644
--- a/drivers/pci/hotplug/rpaphp_core.c
+++ b/drivers/pci/hotplug/rpaphp_core.c
@@ -412,7 +412,6 @@ static void __exit cleanup_slots(void)
412 pci_hp_deregister(&slot->hotplug_slot); 412 pci_hp_deregister(&slot->hotplug_slot);
413 dealloc_slot_struct(slot); 413 dealloc_slot_struct(slot);
414 } 414 }
415 return;
416} 415}
417 416
418static int __init rpaphp_init(void) 417static int __init rpaphp_init(void)
diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index bc7b27a28795..36891e7deee3 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -353,7 +353,7 @@ EXPORT_SYMBOL_GPL(devm_of_pci_get_host_bridge_resources);
353/** 353/**
354 * of_irq_parse_pci - Resolve the interrupt for a PCI device 354 * of_irq_parse_pci - Resolve the interrupt for a PCI device
355 * @pdev: the device whose interrupt is to be resolved 355 * @pdev: the device whose interrupt is to be resolved
356 * @out_irq: structure of_irq filled by this function 356 * @out_irq: structure of_phandle_args filled by this function
357 * 357 *
358 * This function resolves the PCI interrupt for a given PCI device. If a 358 * This function resolves the PCI interrupt for a given PCI device. If a
359 * device-node exists for a given pci_dev, it will use normal OF tree 359 * device-node exists for a given pci_dev, it will use normal OF tree
diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
index 9ae9fb9339e8..5486f8768c86 100644
--- a/drivers/pci/vc.c
+++ b/drivers/pci/vc.c
@@ -411,7 +411,6 @@ void pci_restore_vc_state(struct pci_dev *dev)
411 * For each type of VC capability, VC/VC9/MFVC, find the capability, size 411 * For each type of VC capability, VC/VC9/MFVC, find the capability, size
412 * it, and allocate a buffer for save/restore. 412 * it, and allocate a buffer for save/restore.
413 */ 413 */
414
415void pci_allocate_vc_save_buffers(struct pci_dev *dev) 414void pci_allocate_vc_save_buffers(struct pci_dev *dev)
416{ 415{
417 int i; 416 int i;
diff --git a/include/linux/pci.h b/include/linux/pci.h
index c1c2e4c7242a..deecf3cc17b1 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -971,7 +971,7 @@ resource_size_t pcibios_align_resource(void *, const struct resource *,
971 resource_size_t, 971 resource_size_t,
972 resource_size_t); 972 resource_size_t);
973 973
974/* Weak but can be overriden by arch */ 974/* Weak but can be overridden by arch */
975void pci_fixup_cardbus(struct pci_bus *); 975void pci_fixup_cardbus(struct pci_bus *);
976 976
977/* Generic PCI functions used internally */ 977/* Generic PCI functions used internally */
@@ -1791,7 +1791,7 @@ static inline int pci_ats_page_aligned(struct pci_dev *dev) { return 0; }
1791 1791
1792#include <asm/pci.h> 1792#include <asm/pci.h>
1793 1793
1794/* These two functions provide almost identical functionality. Depennding 1794/* These two functions provide almost identical functionality. Depending
1795 * on the architecture, one will be implemented as a wrapper around the 1795 * on the architecture, one will be implemented as a wrapper around the
1796 * other (in drivers/pci/mmap.c). 1796 * other (in drivers/pci/mmap.c).
1797 * 1797 *