diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2017-01-12 10:19:21 -0500 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2017-01-23 03:02:28 -0500 |
| commit | bdf6f135973acb409b3ec5a6214fb597670a0bc0 (patch) | |
| tree | 9d3da9243bad18a8711c61a50d61246708489387 | |
| parent | 899cc5f14054267b89ebeef4d3c749473ab28eed (diff) | |
drm/hisilicon/hibmc: Fix wrong pointer passed to PTR_ERR()
PTR_ERR should access the value just tested by IS_ERR, otherwise
the wrong error code will be returned.
Fixes: d1667b86795a ("drm/hisilicon/hibmc: Add support for frame buffer")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170112151921.16538-1-weiyj.lk@gmail.com
| -rw-r--r-- | drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c index 7a6957ae4b44..16fe79053ee1 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | |||
| @@ -121,7 +121,7 @@ static int hibmc_drm_fb_create(struct drm_fb_helper *helper, | |||
| 121 | 121 | ||
| 122 | hi_fbdev->fb = hibmc_framebuffer_init(priv->dev, &mode_cmd, gobj); | 122 | hi_fbdev->fb = hibmc_framebuffer_init(priv->dev, &mode_cmd, gobj); |
| 123 | if (IS_ERR(hi_fbdev->fb)) { | 123 | if (IS_ERR(hi_fbdev->fb)) { |
| 124 | ret = PTR_ERR(info); | 124 | ret = PTR_ERR(hi_fbdev->fb); |
| 125 | DRM_ERROR("failed to initialize framebuffer: %d\n", ret); | 125 | DRM_ERROR("failed to initialize framebuffer: %d\n", ret); |
| 126 | goto out_release_fbi; | 126 | goto out_release_fbi; |
| 127 | } | 127 | } |