diff options
author | Arnd Bergmann <arnd@arndb.de> | 2019-03-04 15:38:03 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-03-04 16:14:34 -0500 |
commit | a154d5d83d21af6b9ee32adc5dbcea5ac1fb534c (patch) | |
tree | 742a25ce5320613044083249ba3571eb0899f061 | |
parent | 64af7dc35f0fc8d3435327c44ef50359bdbe2c67 (diff) |
net: ignore sysctl_devconf_inherit_init_net without SYSCTL
When CONFIG_SYSCTL is turned off, we get a link failure for
the newly introduced tuning knob.
net/ipv6/addrconf.o: In function `addrconf_init_net':
addrconf.c:(.text+0x31dc): undefined reference to `sysctl_devconf_inherit_init_net'
Add an IS_ENABLED() check to fall back to the default behavior
(sysctl_devconf_inherit_init_net=0) here.
Fixes: 856c395cfa63 ("net: introduce a knob to control whether to inherit devconf config")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Christian Brauner <christian@brauner.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv4/devinet.c | 4 | ||||
-rw-r--r-- | net/ipv6/addrconf.c | 3 |
2 files changed, 5 insertions, 2 deletions
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index cd9033245b98..eb514f312e6f 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c | |||
@@ -2614,7 +2614,9 @@ static __net_init int devinet_init_net(struct net *net) | |||
2614 | tbl[0].extra2 = net; | 2614 | tbl[0].extra2 = net; |
2615 | #endif | 2615 | #endif |
2616 | 2616 | ||
2617 | if (sysctl_devconf_inherit_init_net != 2 && !net_eq(net, &init_net)) { | 2617 | if ((!IS_ENABLED(CONFIG_SYSCTL) || |
2618 | sysctl_devconf_inherit_init_net != 2) && | ||
2619 | !net_eq(net, &init_net)) { | ||
2618 | memcpy(all, init_net.ipv4.devconf_all, sizeof(ipv4_devconf)); | 2620 | memcpy(all, init_net.ipv4.devconf_all, sizeof(ipv4_devconf)); |
2619 | memcpy(dflt, init_net.ipv4.devconf_dflt, sizeof(ipv4_devconf_dflt)); | 2621 | memcpy(dflt, init_net.ipv4.devconf_dflt, sizeof(ipv4_devconf_dflt)); |
2620 | } | 2622 | } |
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index da5a21050ba9..4ae17a966ae3 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c | |||
@@ -6905,7 +6905,8 @@ static int __net_init addrconf_init_net(struct net *net) | |||
6905 | if (!dflt) | 6905 | if (!dflt) |
6906 | goto err_alloc_dflt; | 6906 | goto err_alloc_dflt; |
6907 | 6907 | ||
6908 | if (sysctl_devconf_inherit_init_net == 1 && !net_eq(net, &init_net)) { | 6908 | if (IS_ENABLED(CONFIG_SYSCTL) && |
6909 | sysctl_devconf_inherit_init_net == 1 && !net_eq(net, &init_net)) { | ||
6909 | memcpy(all, init_net.ipv6.devconf_all, sizeof(ipv6_devconf)); | 6910 | memcpy(all, init_net.ipv6.devconf_all, sizeof(ipv6_devconf)); |
6910 | memcpy(dflt, init_net.ipv6.devconf_dflt, sizeof(ipv6_devconf_dflt)); | 6911 | memcpy(dflt, init_net.ipv6.devconf_dflt, sizeof(ipv6_devconf_dflt)); |
6911 | } | 6912 | } |