diff options
author | Christoph Hellwig <hch@lst.de> | 2018-09-24 03:43:53 -0400 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2018-09-24 14:33:59 -0400 |
commit | 6e768461c215eaf8912e6c23e40fdff1cd962aca (patch) | |
tree | bffe8520b8509cec995de30b555bdc1c5e9f8ed7 | |
parent | 3dccdae54fe836a22cee9dc6df9fd1708ae075ce (diff) |
block: remove bvec_to_phys
We only use it in biovec_phys_mergeable and a m68k paravirt driver,
so just opencode it there. Also remove the pointless unsigned long cast
for the offset in the opencoded instances.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r-- | arch/m68k/emu/nfblock.c | 2 | ||||
-rw-r--r-- | block/blk.h | 4 | ||||
-rw-r--r-- | include/linux/bio.h | 5 |
3 files changed, 3 insertions, 8 deletions
diff --git a/arch/m68k/emu/nfblock.c b/arch/m68k/emu/nfblock.c index e9110b9b8bcd..38049357d6d3 100644 --- a/arch/m68k/emu/nfblock.c +++ b/arch/m68k/emu/nfblock.c | |||
@@ -73,7 +73,7 @@ static blk_qc_t nfhd_make_request(struct request_queue *queue, struct bio *bio) | |||
73 | len = bvec.bv_len; | 73 | len = bvec.bv_len; |
74 | len >>= 9; | 74 | len >>= 9; |
75 | nfhd_read_write(dev->id, 0, dir, sec >> shift, len >> shift, | 75 | nfhd_read_write(dev->id, 0, dir, sec >> shift, len >> shift, |
76 | bvec_to_phys(&bvec)); | 76 | page_to_phys(bvec.bv_page) + bvec.bv_offset); |
77 | sec += len; | 77 | sec += len; |
78 | } | 78 | } |
79 | bio_endio(bio); | 79 | bio_endio(bio); |
diff --git a/block/blk.h b/block/blk.h index 8f7229b6f63e..50f74ce60453 100644 --- a/block/blk.h +++ b/block/blk.h | |||
@@ -157,8 +157,8 @@ static inline bool biovec_phys_mergeable(struct request_queue *q, | |||
157 | struct bio_vec *vec1, struct bio_vec *vec2) | 157 | struct bio_vec *vec1, struct bio_vec *vec2) |
158 | { | 158 | { |
159 | unsigned long mask = queue_segment_boundary(q); | 159 | unsigned long mask = queue_segment_boundary(q); |
160 | phys_addr_t addr1 = bvec_to_phys(vec1); | 160 | phys_addr_t addr1 = page_to_phys(vec1->bv_page) + vec1->bv_offset; |
161 | phys_addr_t addr2 = bvec_to_phys(vec2); | 161 | phys_addr_t addr2 = page_to_phys(vec2->bv_page) + vec2->bv_offset; |
162 | 162 | ||
163 | if (addr1 + vec1->bv_len != addr2) | 163 | if (addr1 + vec1->bv_len != addr2) |
164 | return false; | 164 | return false; |
diff --git a/include/linux/bio.h b/include/linux/bio.h index 9b580e1cb2e8..9ad4b0a487a4 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h | |||
@@ -133,11 +133,6 @@ static inline bool bio_full(struct bio *bio) | |||
133 | } | 133 | } |
134 | 134 | ||
135 | /* | 135 | /* |
136 | * will die | ||
137 | */ | ||
138 | #define bvec_to_phys(bv) (page_to_phys((bv)->bv_page) + (unsigned long) (bv)->bv_offset) | ||
139 | |||
140 | /* | ||
141 | * drivers should _never_ use the all version - the bio may have been split | 136 | * drivers should _never_ use the all version - the bio may have been split |
142 | * before it got to the driver and the driver won't own all of it | 137 | * before it got to the driver and the driver won't own all of it |
143 | */ | 138 | */ |