diff options
author | Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2019-08-05 20:55:09 -0400 |
---|---|---|
committer | Vinod Koul <vkoul@kernel.org> | 2019-08-21 05:06:01 -0400 |
commit | 6e0ac6a663b834b9ea16b2340e66aa3717c465b2 (patch) | |
tree | e953cc58ad5d0b73432251b451ad104e92b28f6d | |
parent | 9b5884a0c60b7194fd62d48f62f893f353f41eb4 (diff) |
soundwire: bus: improve dynamic debug comments for enumeration
update comments to provide better understanding of enumeration flows.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20190806005522.22642-5-pierre-louis.bossart@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
-rw-r--r-- | drivers/soundwire/bus.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index 49f64b2115b9..50f9cc5eb5f6 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c | |||
@@ -470,7 +470,8 @@ static int sdw_assign_device_num(struct sdw_slave *slave) | |||
470 | 470 | ||
471 | ret = sdw_write(slave, SDW_SCP_DEVNUMBER, dev_num); | 471 | ret = sdw_write(slave, SDW_SCP_DEVNUMBER, dev_num); |
472 | if (ret < 0) { | 472 | if (ret < 0) { |
473 | dev_err(&slave->dev, "Program device_num failed: %d\n", ret); | 473 | dev_err(&slave->dev, "Program device_num %d failed: %d\n", |
474 | dev_num, ret); | ||
474 | return ret; | 475 | return ret; |
475 | } | 476 | } |
476 | 477 | ||
@@ -527,6 +528,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) | |||
527 | do { | 528 | do { |
528 | ret = sdw_transfer(bus, &msg); | 529 | ret = sdw_transfer(bus, &msg); |
529 | if (ret == -ENODATA) { /* end of device id reads */ | 530 | if (ret == -ENODATA) { /* end of device id reads */ |
531 | dev_dbg(bus->dev, "No more devices to enumerate\n"); | ||
530 | ret = 0; | 532 | ret = 0; |
531 | break; | 533 | break; |
532 | } | 534 | } |
@@ -969,6 +971,7 @@ int sdw_handle_slave_status(struct sdw_bus *bus, | |||
969 | int i, ret = 0; | 971 | int i, ret = 0; |
970 | 972 | ||
971 | if (status[0] == SDW_SLAVE_ATTACHED) { | 973 | if (status[0] == SDW_SLAVE_ATTACHED) { |
974 | dev_dbg(bus->dev, "Slave attached, programming device number\n"); | ||
972 | ret = sdw_program_device_num(bus); | 975 | ret = sdw_program_device_num(bus); |
973 | if (ret) | 976 | if (ret) |
974 | dev_err(bus->dev, "Slave attach failed: %d\n", ret); | 977 | dev_err(bus->dev, "Slave attach failed: %d\n", ret); |