xfs: more do_div cleanups

On some architectures do_div does the pointer compare
trick to make sure that we've sent it an unsigned 64-bit
number.  (Why unsigned?  I don't know.)

Fix up the few places that squawk about this; in
xfs_bmap_wants_extents() we just used a bare int64_t so change
that to unsigned.

In xfs_adjust_extent_unmap_boundaries() all we wanted was the
mod, and we have an xfs-specific function to handle that w/o
side effects, which includes proper casting for do_div.

In xfs_daddr_to_ag[b]no, we were using the wrong type anyway;
XFS_BB_TO_FSBT returns a block in the filesystem, so use
xfs_rfsblock_t not xfs_daddr_t, and gain the unsignedness
from that type as a bonus.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

3 files changed, 4 insertions, 7 deletions

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 7f42f6067eb5..0fdff08145c1 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -4887,7 +4887,7 @@ xfs_bmap_del_extent_delay(
         ASSERT(got_endoff >= del_endoff);
 
         if (isrt) {
-                int64_t rtexts = XFS_FSB_TO_B(mp, del->br_blockcount);
+                uint64_t rtexts = XFS_FSB_TO_B(mp, del->br_blockcount);
 
                 do_div(rtexts, mp->m_sb.sb_rextsize);
                 xfs_mod_frextents(mp, rtexts);
diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
index de94798f1c1b..7ac80a1facf2 100644
--- a/fs/xfs/xfs_bmap_util.c
+++ b/fs/xfs/xfs_bmap_util.c
@@ -1206,11 +1206,8 @@ xfs_adjust_extent_unmap_boundaries(
                 return error;
 
         if (nimap && imap.br_startblock != HOLESTARTBLOCK) {
-                xfs_daddr_t     block;
-
                 ASSERT(imap.br_startblock != DELAYSTARTBLOCK);
-                block = imap.br_startblock;
-                mod = do_div(block, mp->m_sb.sb_rextsize);
+                mod = do_mod(imap.br_startblock, mp->m_sb.sb_rextsize);
                 if (mod)
                         *startoffset_fsb += mp->m_sb.sb_rextsize - mod;
         }
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
index 22b2185e93a0..9fa312a41c93 100644
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -313,7 +313,7 @@ void xfs_do_force_shutdown(struct xfs_mount *mp, int flags, char *fname,
 static inline xfs_agnumber_t
 xfs_daddr_to_agno(struct xfs_mount *mp, xfs_daddr_t d)
 {
-        xfs_daddr_t ld = XFS_BB_TO_FSBT(mp, d);
+        xfs_rfsblock_t ld = XFS_BB_TO_FSBT(mp, d);
         do_div(ld, mp->m_sb.sb_agblocks);
         return (xfs_agnumber_t) ld;
 }
@@ -321,7 +321,7 @@ xfs_daddr_to_agno(struct xfs_mount *mp, xfs_daddr_t d)
 static inline xfs_agblock_t
 xfs_daddr_to_agbno(struct xfs_mount *mp, xfs_daddr_t d)
 {
-        xfs_daddr_t ld = XFS_BB_TO_FSBT(mp, d);
+        xfs_rfsblock_t ld = XFS_BB_TO_FSBT(mp, d);
         return (xfs_agblock_t) do_div(ld, mp->m_sb.sb_agblocks);
 }