summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKonstantin Khlebnikov <khlebnikov@yandex-team.ru>2019-03-29 10:01:18 -0400
committerJens Axboe <axboe@kernel.dk>2019-04-01 08:56:15 -0400
commit42b1bd33dcdef4ffd98f695e188bab82f9fa46d8 (patch)
treedb99a97b9635a3216ce75820070a4b43b73c9bd0
parent79a3aaa7b82e3106be97842dedfd8429248896e6 (diff)
block/bfq: fix ifdef for CONFIG_BFQ_GROUP_IOSCHED=y
Replace BFQ_GROUP_IOSCHED_ENABLED with CONFIG_BFQ_GROUP_IOSCHED. Code under these ifdefs never worked, something might be broken. Fixes: 0471559c2fbd ("block, bfq: add/remove entity weights correctly") Fixes: 73d58118498b ("block, bfq: consider also ioprio classes in symmetry detection") Reviewed-by: Holger Hoffstätte <holger@applied-asynchrony.com> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--block/bfq-iosched.c2
-rw-r--r--block/bfq-wf2q.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index 4c592496a16a..fac188dd78fa 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -674,7 +674,7 @@ static bool bfq_symmetric_scenario(struct bfq_data *bfqd)
674 * at least two nodes. 674 * at least two nodes.
675 */ 675 */
676 return !(varied_queue_weights || multiple_classes_busy 676 return !(varied_queue_weights || multiple_classes_busy
677#ifdef BFQ_GROUP_IOSCHED_ENABLED 677#ifdef CONFIG_BFQ_GROUP_IOSCHED
678 || bfqd->num_groups_with_pending_reqs > 0 678 || bfqd->num_groups_with_pending_reqs > 0
679#endif 679#endif
680 ); 680 );
diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
index 63311d1ff1ed..a11bef75483d 100644
--- a/block/bfq-wf2q.c
+++ b/block/bfq-wf2q.c
@@ -1012,7 +1012,7 @@ static void __bfq_activate_entity(struct bfq_entity *entity,
1012 entity->on_st = true; 1012 entity->on_st = true;
1013 } 1013 }
1014 1014
1015#ifdef BFQ_GROUP_IOSCHED_ENABLED 1015#ifdef CONFIG_BFQ_GROUP_IOSCHED
1016 if (!bfq_entity_to_bfqq(entity)) { /* bfq_group */ 1016 if (!bfq_entity_to_bfqq(entity)) { /* bfq_group */
1017 struct bfq_group *bfqg = 1017 struct bfq_group *bfqg =
1018 container_of(entity, struct bfq_group, entity); 1018 container_of(entity, struct bfq_group, entity);