summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2011-05-25 05:34:52 -0400
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2011-08-19 04:34:34 -0400
commit305e0e4dbcd038625786a40e9fa801ba5b18b2a2 (patch)
treef25c00f5c4759167ec2ad1d6400e0a09c181307b
parentd8e7a74bf1f1c3d8235e1d939d3e1e96da94ed82 (diff)
s3fb: use display information in info not in var for panning
We must not use any information in the passed var besides xoffset, yoffset and vmode as otherwise applications might abuse it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-rw-r--r--drivers/video/s3fb.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/video/s3fb.c b/drivers/video/s3fb.c
index 4ca5d0c8fe84..0f9af1aa5077 100644
--- a/drivers/video/s3fb.c
+++ b/drivers/video/s3fb.c
@@ -1019,12 +1019,13 @@ static int s3fb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info)
1019 unsigned int offset; 1019 unsigned int offset;
1020 1020
1021 /* Calculate the offset */ 1021 /* Calculate the offset */
1022 if (var->bits_per_pixel == 0) { 1022 if (info->var.bits_per_pixel == 0) {
1023 offset = (var->yoffset / 16) * (var->xres_virtual / 2) + (var->xoffset / 2); 1023 offset = (var->yoffset / 16) * (info->var.xres_virtual / 2)
1024 + (var->xoffset / 2);
1024 offset = offset >> 2; 1025 offset = offset >> 2;
1025 } else { 1026 } else {
1026 offset = (var->yoffset * info->fix.line_length) + 1027 offset = (var->yoffset * info->fix.line_length) +
1027 (var->xoffset * var->bits_per_pixel / 8); 1028 (var->xoffset * info->var.bits_per_pixel / 8);
1028 offset = offset >> 2; 1029 offset = offset >> 2;
1029 } 1030 }
1030 1031