diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-07-17 02:17:50 -0400 |
---|---|---|
committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-07-17 09:39:27 -0400 |
commit | 1bd9a468018dd318283c7c620729ddf1923f2024 (patch) | |
tree | a7e65fc6bc709a9aab1cbd74400bcb70354e324e | |
parent | 7e13191879d6d589cd987a8db3a70019251fc757 (diff) |
kbuild: get rid of kernel/ prefix from in-tree modules.{order,builtin}
Removing the 'kernel/' prefix will make our life easier because we can
simply do 'cat modules.order' to get all built modules with full paths.
Currently, we parse the first line of '*.mod' files in $(MODVERDIR).
Since we have duplicated functionality here, I plan to remove MODVERDIR
entirely.
In fact, modules.order is generated also for external modules in a
broken format. It adds the 'kernel/' prefix to the absolute path of
the module, like this:
kernel//path/to/your/external/module/foo.ko
This is fine for now since modules.order is not used for external
modules. However, I want to sanitize the format everywhere towards
the goal of removing MODVERDIR.
We cannot change the format of installed module.{order,builtin}.
So, 'make modules_install' will add the 'kernel/' prefix while copying
them to $(MODLIB)/.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
-rw-r--r-- | Makefile | 4 | ||||
-rw-r--r-- | scripts/Makefile.build | 2 | ||||
-rw-r--r-- | scripts/Makefile.modbuiltin | 2 | ||||
-rwxr-xr-x | scripts/modules-check.sh | 2 |
4 files changed, 5 insertions, 5 deletions
@@ -1329,8 +1329,8 @@ _modinst_: | |||
1329 | rm -f $(MODLIB)/build ; \ | 1329 | rm -f $(MODLIB)/build ; \ |
1330 | ln -s $(CURDIR) $(MODLIB)/build ; \ | 1330 | ln -s $(CURDIR) $(MODLIB)/build ; \ |
1331 | fi | 1331 | fi |
1332 | @cp -f $(objtree)/modules.order $(MODLIB)/ | 1332 | @sed 's:^:kernel/:' modules.order > $(MODLIB)/modules.order |
1333 | @cp -f $(objtree)/modules.builtin $(MODLIB)/ | 1333 | @sed 's:^:kernel/:' modules.builtin > $(MODLIB)/modules.builtin |
1334 | @cp -f $(objtree)/modules.builtin.modinfo $(MODLIB)/ | 1334 | @cp -f $(objtree)/modules.builtin.modinfo $(MODLIB)/ |
1335 | $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst | 1335 | $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst |
1336 | 1336 | ||
diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 631bb89524de..10e92a27ec20 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build | |||
@@ -426,7 +426,7 @@ endif # builtin-target | |||
426 | modorder-cmds = \ | 426 | modorder-cmds = \ |
427 | $(foreach m, $(modorder), \ | 427 | $(foreach m, $(modorder), \ |
428 | $(if $(filter %/modules.order, $m), \ | 428 | $(if $(filter %/modules.order, $m), \ |
429 | cat $m;, echo kernel/$m;)) | 429 | cat $m;, echo $m;)) |
430 | 430 | ||
431 | $(modorder-target): $(subdir-ym) FORCE | 431 | $(modorder-target): $(subdir-ym) FORCE |
432 | $(Q)(cat /dev/null; $(modorder-cmds)) > $@ | 432 | $(Q)(cat /dev/null; $(modorder-cmds)) > $@ |
diff --git a/scripts/Makefile.modbuiltin b/scripts/Makefile.modbuiltin index 50a9990760f3..7d4711b88656 100644 --- a/scripts/Makefile.modbuiltin +++ b/scripts/Makefile.modbuiltin | |||
@@ -40,7 +40,7 @@ __modbuiltin: $(modbuiltin-target) $(subdir-ym) | |||
40 | @: | 40 | @: |
41 | 41 | ||
42 | $(modbuiltin-target): $(subdir-ym) FORCE | 42 | $(modbuiltin-target): $(subdir-ym) FORCE |
43 | $(Q)(for m in $(modbuiltin-mods); do echo kernel/$$m; done; \ | 43 | $(Q)(for m in $(modbuiltin-mods); do echo $$m; done; \ |
44 | cat /dev/null $(modbuiltin-subdirs)) > $@ | 44 | cat /dev/null $(modbuiltin-subdirs)) > $@ |
45 | 45 | ||
46 | PHONY += FORCE | 46 | PHONY += FORCE |
diff --git a/scripts/modules-check.sh b/scripts/modules-check.sh index 39e8cb36ba19..f51f446707b8 100755 --- a/scripts/modules-check.sh +++ b/scripts/modules-check.sh | |||
@@ -9,7 +9,7 @@ check_same_name_modules() | |||
9 | for m in $(sed 's:.*/::' modules.order | sort | uniq -d) | 9 | for m in $(sed 's:.*/::' modules.order | sort | uniq -d) |
10 | do | 10 | do |
11 | echo "warning: same module names found:" >&2 | 11 | echo "warning: same module names found:" >&2 |
12 | sed -n "/\/$m/s:^kernel/: :p" modules.order >&2 | 12 | sed -n "/\/$m/s:^: :p" modules.order >&2 |
13 | done | 13 | done |
14 | } | 14 | } |
15 | 15 | ||