summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndy Lutomirski <luto@kernel.org>2018-04-03 18:39:26 -0400
committerIngo Molnar <mingo@kernel.org>2018-04-09 12:23:50 -0400
commit071ccc966ba5db1ac8f5c24b0faebb37698f68db (patch)
tree47e024d956113461ee2ccab53115f4efd18ff432
parent9820e1c3376c641299624dd24646aed3167ad5b1 (diff)
x86/entry/64: Drop idtentry's manual stack switch for user entries
For non-paranoid entries, idtentry knows how to switch from the kernel stack to the user stack, as does error_entry. This results in pointless duplication and code bloat. Make idtentry stop thinking about stacks for non-paranoid entries. This reduces text size by 5377 bytes. This goes back to the following commit: 7f2590a110b8 ("x86/entry/64: Use a per-CPU trampoline stack for IDT entries") Signed-off-by: Andy Lutomirski <luto@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Dominik Brodowski <linux@dominikbrodowski.net> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/90aab80c1f906e70742eaa4512e3c9b5e62d59d4.1522794757.git.luto@kernel.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--arch/x86/entry/entry_64.S4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 9b114675fbc0..e237913a056b 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -908,7 +908,7 @@ ENTRY(\sym)
908 pushq $-1 /* ORIG_RAX: no syscall to restart */ 908 pushq $-1 /* ORIG_RAX: no syscall to restart */
909 .endif 909 .endif
910 910
911 .if \paranoid < 2 911 .if \paranoid == 1
912 testb $3, CS-ORIG_RAX(%rsp) /* If coming from userspace, switch stacks */ 912 testb $3, CS-ORIG_RAX(%rsp) /* If coming from userspace, switch stacks */
913 jnz .Lfrom_usermode_switch_stack_\@ 913 jnz .Lfrom_usermode_switch_stack_\@
914 .endif 914 .endif
@@ -955,7 +955,7 @@ ENTRY(\sym)
955 jmp error_exit 955 jmp error_exit
956 .endif 956 .endif
957 957
958 .if \paranoid < 2 958 .if \paranoid == 1
959 /* 959 /*
960 * Entry from userspace. Switch stacks and treat it 960 * Entry from userspace. Switch stacks and treat it
961 * as a normal entry. This means that paranoid handlers 961 * as a normal entry. This means that paranoid handlers